Java: Introduce a class of dataflow nodes for the threat modeling.#14257
Merged
michaelnebel merged 6 commits intogithub:mainfrom Oct 3, 2023
Merged
Java: Introduce a class of dataflow nodes for the threat modeling.#14257michaelnebel merged 6 commits intogithub:mainfrom
michaelnebel merged 6 commits intogithub:mainfrom
Conversation
9137397 to
52e8d6f
Compare
3323f6c to
512b386
Compare
Contributor
Author
|
DCA looks good! |
aschackmull
reviewed
Oct 2, 2023
83b7c82 to
29f4731
Compare
…fine grain the LocalUserInput threat models.
29f4731 to
5b949b1
Compare
aschackmull
reviewed
Oct 3, 2023
aschackmull
approved these changes
Oct 3, 2023
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
I've not really looked through the tests and their output, but the QL LGTM now.
Contributor
Author
Thank you @aschackmull ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a class of data flow nodes called
ThreatModelFlowSource.The idea is that these are the exact source nodes we are interested in under a given threat model.
For more background information see EDR.
With this implementation it will also be easy to for a query to "opt-in" to threat models as defined by the
ThreatModelFlowSourceby updating the data flow configuration.With this change, we can convert most of the data flow related queries that are based on
RemoteFlowSourcetoThreatModelFlowSourceas this (should) yield the same results as long as the default threat model is used (the default only contains remote).