Swift: Unify ArrayContent and CollectionContent#14205
Merged
rdmarsh2 merged 9 commits intogithub:mainfrom Sep 14, 2023
Merged
Conversation
Contributor
|
Grep'ing for Should this technically have a breaking change note? |
geoffw0
reviewed
Sep 13, 2023
Contributor
geoffw0
left a comment
There was a problem hiding this comment.
Otherwise LGTM. Thank you for doing this!
Needs a DCA run IMO.
| or | ||
| component.getName() = "ArrayElement" and | ||
| content instanceof Content::ArrayContent | ||
| or |
Contributor
There was a problem hiding this comment.
May I suggest we don't delete this case, but make it a synonym for CollectionElement. We can carefully ensure we're not using it ourselves, but that way we'll avoid breaking any user code that uses ArrayElement.
geoffw0
reviewed
Sep 13, 2023
geoffw0
reviewed
Sep 13, 2023
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Contributor
Author
|
DCA looks good, there's a fair bit of noise but I think this is actually a meaningful speedup overall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.