Swift: add SetContent for data flow#13838
Merged
geoffw0 merged 10 commits intogithub:mainfrom Aug 7, 2023
Merged
Conversation
geoffw0
reviewed
Jul 31, 2023
Contributor
|
Also small nitpick: How about just calling this |
Contributor
I like this idea. |
geoffw0
reviewed
Aug 3, 2023
| cs.isSingleton(c) and | ||
| result = "EnumElement[" + c.getSignature() + "]" | ||
| ) | ||
| or |
Contributor
There was a problem hiding this comment.
Thanks for adding this, I missed it in #13795 .
geoffw0
reviewed
Aug 3, 2023
|
|
||
| let set2 = Set([source()]) | ||
| sink(arg: set2.randomElement()!) // $ MISSING: flow=703 | ||
| sink(arg: set2.randomElement()!) // $ flow=706 |
Contributor
|
Do you mind rebasing this on the latest main so that we get a smaller diff @rdmarsh2? |
MathiasVP
reviewed
Aug 4, 2023
| TEnumContent(ParamDecl f) { exists(EnumElementDecl d | d.getAParam() = f) } or | ||
| TArrayContent() | ||
| TArrayContent() or | ||
| TSetContent() |
Contributor
There was a problem hiding this comment.
I still think we should call this CollectionContent (see #13838 (comment))
3bcf28e to
024c5cf
Compare
geoffw0
reviewed
Aug 4, 2023
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
MathiasVP
previously approved these changes
Aug 7, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once we have a successful DCA run!
MathiasVP
approved these changes
Aug 7, 2023
geoffw0
approved these changes
Aug 7, 2023
Contributor
geoffw0
left a comment
There was a problem hiding this comment.
This looks great, and I could use the readStep fix in two of my open PRs and CollectionContent in one, so the sooner we merge this the better!
Contributor
|
DCA LGTM. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.