Java: Fix Gson's JsonArray.add models#13394
Merged
aschackmull merged 2 commits intogithub:mainfrom Jun 8, 2023
Merged
Conversation
When the type of the argument isn't JsonElement, the summary must be taint flow instead of value flow
aschackmull
reviewed
Jun 7, 2023
| // "com.google.gson;JsonArray;true;add;(JsonArray);;Argument[0].Element;Argument[this].Element;value;manual" | ||
| JsonArray out = null; | ||
| String in = (String)source(); | ||
| JsonElement in = (JsonElement)source(); |
Contributor
There was a problem hiding this comment.
Something's off here. This test case is now a duplicate of the one two cases above. And we're no longer testing add(String), which I'm guessing is a much more important case than silly cases like a tainted boolean.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this. Since JsonArray.addAll wasn't properly modeled, I got confused while updating the tests. c013567 should get it right.
Properly test JsonArray.add(String) and JsonArray.addAll(JsonArray) as well
aschackmull
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Gson JsonArray.add models detected by @aschackmull in #13083.
When the type of the argument isn't
JsonElement, the summary must be taint flow instead of value flow, because the type changes.