C++: Take into account the delta at the final sink in cpp/invalid-pointer-deref#13320
C++: Take into account the delta at the final sink in cpp/invalid-pointer-deref#13320MathiasVP merged 5 commits intogithub:mainfrom
cpp/invalid-pointer-deref#13320Conversation
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once DCA is happy!
| joinOn2(node1.asPathNode3(), node2.asSinkNode(), _, _) | ||
| } | ||
|
|
||
| query predicate nodes(MergedPathNode n, string key, string val) { |
There was a problem hiding this comment.
FWIW nodes is implicitly generated by the CLI in a path-problem query based on the edges predicate. So strictly speaking this query predicate is redundant (since we're not using it to modify the string representation of the nodes). However, I do like having the nodes predicate in here since it can be useful to append concat(n.getAQlClass(), ", ") for debugging purposes.
There was a problem hiding this comment.
Ah, learnt something new. Thanks.
There was a problem hiding this comment.
I don't blame you. I don't think this is documented anywhere 😅
|
DCA alert changes look correct, except for the CMake one, but this one is related to an FP (without |
While here, fix the dataflow configuration names as they occur in the comments, and add the
nodesquery predicate, which seemed to be missing. Commit-by-commit review is recommended.