Swift: remove unneeded properties from InterpolatedStringLiteralExpr#13238
Merged
redsun82 merged 4 commits intocodeql-cli-2.13.3from May 23, 2023
Merged
Conversation
These properties were unused in the QL library (hence the full upgrade/downgrade compatibility).
84d751d to
9a0f874
Compare
geoffw0
reviewed
May 22, 2023
Contributor
geoffw0
left a comment
There was a problem hiding this comment.
A couple of questions, but LGTM.
…m-interpolated-strings
Contributor
Author
|
DCA looks good as far as I'm concerned, this can be merged as soon as CI is happy. |
…m-interpolated-strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These properties were unused in the QL library (hence the full upgrade/downgrade compatibility).