C++: Only one alert message per alert on cpp/overrun-write#13041
Merged
MathiasVP merged 4 commits intogithub:mainfrom May 9, 2023
Merged
C++: Only one alert message per alert on cpp/overrun-write#13041MathiasVP merged 4 commits intogithub:mainfrom
cpp/overrun-write#13041MathiasVP merged 4 commits intogithub:mainfrom
Conversation
Contributor
Author
|
DCA looks fine. The lost result is just the fact that we now just have one alert at https://github.com/systemd/systemd/blob/main/src/basic/memory-util.h#L24 (instead of 32 alerts). |
jketema
reviewed
May 8, 2023
Contributor
jketema
left a comment
There was a problem hiding this comment.
One question, otherwise this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of alert messages on a given alert on the
cpp/overrun-writequery.Commit-by-commit review recommended.