Skip to content

Java: Minor perf fix for typePrefixContainsAux1. #13036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 1 commit into from
May 9, 2023
Merged

Java: Minor perf fix for typePrefixContainsAux1. #13036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions java/ql/lib/semmle/code/java/Type.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,19 @@ private predicate typePrefixContains_ext_neq(ParameterizedPrefix pps, Parameteri
)
}

pragma[nomagic]
private TTypeParam parameterizedPrefixWithWildcard(ParameterizedPrefix pps0, Wildcard s) {
result = TTypeParam(pps0, s)
}

pragma[nomagic]
private predicate typePrefixContainsAux1(
ParameterizedPrefix pps, ParameterizedPrefix ppt0, RefType s
) {
exists(ParameterizedPrefix pps0 |
typePrefixContains(pps0, ppt0) and
pps = TTypeParam(pps0, s) and
s instanceof Wildcard // manual magic, implied by `typeArgumentContains(_, s, t, _)`
// `s instanceof Wildcard` is manual magic, implied by `typeArgumentContains(_, s, t, _)`
pps = parameterizedPrefixWithWildcard(pps0, s)
)
}

Expand Down