Skip to content

Swift: Fix TODOs in FlowSummary.qll #13013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 1 commit into from
May 3, 2023
Merged

Swift: Fix TODOs in FlowSummary.qll #13013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions swift/ql/lib/codeql/swift/dataflow/FlowSummary.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,11 @@ module SummaryComponent {

predicate content = SummaryComponentInternal::content/1;

/** Gets a summary component for parameter `i`. */
SummaryComponent parameter(int i) {
none() // TODO
}
predicate parameter = SummaryComponentInternal::parameter/1;

/** Gets a summary component for argument `i`. */
SummaryComponent argument(int i) {
none() // TODO
}
predicate argument = SummaryComponentInternal::argument/1;

predicate return = SummaryComponentInternal::return/1;

/** Gets a summary component that represents a qualifier. */
SummaryComponent qualifier() {
none() // TODO
}

/** Gets a summary component that represents the return value of a call. */
SummaryComponent return() { result = return(any(DataFlowDispatch::NormalReturnKind rk)) }
}

class SummaryComponentStack = Impl::Public::SummaryComponentStack;
Expand All @@ -52,16 +38,9 @@ module SummaryComponentStack {

predicate push = SummaryComponentStackInternal::push/2;

/** Gets a singleton stack for argument `i`. */
SummaryComponentStack argument(int i) { result = singleton(SummaryComponent::argument(i)) }
predicate argument = SummaryComponentStackInternal::argument/1;

predicate return = SummaryComponentStackInternal::return/1;

/** Gets a singleton stack representing a qualifier. */
SummaryComponentStack qualifier() { result = singleton(SummaryComponent::qualifier()) }

/** Gets a singleton stack representing the return value of a call. */
SummaryComponentStack return() { result = singleton(SummaryComponent::return()) }
}

class SummarizedCallable = Impl::Public::SummarizedCallable;
Expand Down