Skip to content

JS: Allow NonKeyCiphers to include truncated SHA-512 MDs in Forge JS libr… #12825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 5 commits into from
May 2, 2023
Merged

JS: Allow NonKeyCiphers to include truncated SHA-512 MDs in Forge JS libr… #12825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec97cdc
Allow NonKeyCiphers to include truncated SHA-512 MDs in Forge JS libr…
smiddy007 Apr 14, 2023
31b56bf
Update javascript/ql/lib/change-notes/2023-04-13-Forge-truncated-sha5…
smiddy007 Apr 19, 2023
4f7275f
Reformat doc and move change note
smiddy007 Apr 19, 2023
bda0ef3
Merge branch 'github:main' into JS-Allow-Truncated-Hash-Forge-NonKeyC…
smiddy007 Apr 19, 2023
a2a82fc
Merge branch 'main' into JS-Allow-Truncated-Hash-Forge-NonKeyCipher
smiddy007 Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,15 @@ private module Forge {
// require("forge").md.md5.create().update('The quick brown fox jumps over the lazy dog');
this =
getAnImportNode().getMember("md").getMember(algorithmName).getMember("create").getACall()
or
// require("forge").sha512.sha256.create().update('The quick brown fox jumps over the lazy dog');
this =
getAnImportNode()
.getMember("md")
.getMember(algorithmName)
.getAMember()
.getMember("create")
.getACall()
)
}

Expand Down
5 changes: 5 additions & 0 deletions javascript/ql/src/change-notes/2023-04-13-Forge-truncated-sha512-hash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: minorAnalysis
---
* The Forge module in `CryptoLibraries.qll` now correctly classifies SHA-512/224,
SHA-512/256, and SHA-512/384 hashes used in message digests as NonKeyCiphers.