Skip to content

Java: Move more dataflow configurations to *Query.qll files#12721

Merged
egregius313 merged 23 commits intogithub:mainfrom
egregius313:egregius313/java/move-configurations-to-libraries
May 5, 2023
Merged

Java: Move more dataflow configurations to *Query.qll files#12721
egregius313 merged 23 commits intogithub:mainfrom
egregius313:egregius313/java/move-configurations-to-libraries

Conversation

@egregius313
Copy link
Copy Markdown
Contributor

@egregius313 egregius313 commented Mar 31, 2023 •
edited
Loading

Moves configurations defined in query files to their own files under java/ql/lib, making them importable.

@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from 8f91949 to 5d84728 Compare March 31, 2023 02:33
@owen-mc owen-mc changed the title Move more dataflow configurations to *Query.qll files Java: Move more dataflow configurations to *Query.qll files Mar 31, 2023
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch 2 times, most recently from 12dcabe to 44b6e86 Compare April 4, 2023 15:22
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 5, 2023
View reviewed changes
Comment thread java/ql/lib/semmle/code/java/security/StackTraceExposureQuery.qll Fixed
Comment thread java/ql/lib/semmle/code/java/security/StackTraceExposureQuery.qll Fixed
Comment thread java/ql/lib/semmle/code/java/security/StackTraceExposureQuery.qll Fixed
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from e8c9b57 to 7c1a1a4 Compare April 6, 2023 20:23
@egregius313 egregius313 marked this pull request as ready for review April 11, 2023 23:57
@egregius313 egregius313 requested a review from a team as a code owner April 11, 2023 23:57
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch 3 times, most recently from 2a18631 to 1804292 Compare April 18, 2023 03:52
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch 2 times, most recently from 4059fd4 to 850ed80 Compare April 24, 2023 11:08
atorralba
atorralba reviewed Apr 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, the majority of my comments are about import visibility. If I missed something that would break when making something private, please just say so and move on :) (i.e. don't jump through hoops to get it done)

Comment thread java/ql/lib/semmle/code/java/security/ArithmeticTaintedLocalQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/ArithmeticUncontrolledQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/ArithmeticWithExtremeValuesQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/ArithmeticWithExtremeValuesQuery.qll
Comment thread java/ql/lib/semmle/code/java/security/BrokenCryptoAlgorithmQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/UrlRedirectLocalQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/UrlRedirectQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/XPathInjectionQuery.qll Outdated
Comment thread java/ql/lib/semmle/code/java/security/XPathInjectionQuery.qll
Comment thread java/ql/lib/semmle/code/java/security/XssLocalQuery.qll Outdated
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from 826cdaf to 631e262 Compare May 3, 2023 15:48
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch 5 times, most recently from 7b2610c to ce4ddb1 Compare May 3, 2023 21:32
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from ce4ddb1 to 5f3c8fe Compare May 4, 2023 14:25
atorralba
atorralba approved these changes May 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is green, LGTM!

@egregius313 egregius313 merged commit 2d5b350 into github:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@egregius313 @atorralba @github-advanced-security