Swift: Hide LValueType in the main AST#11566
Merged
MathiasVP merged 5 commits intogithub:mainfrom Dec 8, 2022
Merged
Conversation
redsun82
reviewed
Dec 5, 2022
Contributor
redsun82
left a comment
There was a problem hiding this comment.
Why is this causing so many changes in the dataflow test?
Contributor
Author
This is because we now recognize more Now, it can be argued that some of these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:til: that lvalues are annotated with an
LValueTypein the AST. I don't think this is a very user-friendly type to have pop up in the "main AST" (it certainly surprised me!).This PR hide those
LValueTypes from the main AST.