Swift: add an internal query-suite for listing all the compiler errors#11181
Merged
Swift: add an internal query-suite for listing all the compiler errors#11181
Conversation
MathiasVP
reviewed
Nov 9, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
One small comment. Otherwise, LGTM!
If you do end up changing the id it would also be awesome to add in those missing this qualifiers that Code Scanning is complaining about. People really want those implicit thiss to disappear from our repo 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.