Skip to content

Kotlin: Exclude .kt files from java/unreachable-catch-clause#10962

Merged
tamasvajk merged 2 commits intogithub:mainfrom
tamasvajk:kotlin-unreachable-catch
Oct 25, 2022
Merged

Kotlin: Exclude .kt files from java/unreachable-catch-clause#10962
tamasvajk merged 2 commits intogithub:mainfrom
tamasvajk:kotlin-unreachable-catch

Conversation

@tamasvajk
Copy link
Copy Markdown
Contributor

No description provided.

@tamasvajk tamasvajk marked this pull request as ready for review October 25, 2022 10:40
@tamasvajk tamasvajk requested a review from a team as a code owner October 25, 2022 10:40
@tamasvajk tamasvajk requested review from a team and removed request for a team October 25, 2022 10:40
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Oct 25, 2022
Copy link
Copy Markdown
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say a bit about why we're excluding Kotlin?

@tamasvajk
Copy link
Copy Markdown
Contributor Author

Can you say a bit about why we're excluding Kotlin?

There's some detail in the linked internal issue. The main reason is that we're not extracting the exceptions relation in the Kotlin extractor, and this check is heavily based on that.

@tamasvajk tamasvajk merged commit 3264bbc into github:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Kotlin no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants