CI: fix qhelp preview#10753
Merged
aibaars merged 1 commit intogithub:mainfrom Oct 10, 2022
Merged
Conversation
The command to gather the changed files uses NULL character terminated "lines", therefore we should supply the `-z` flag to `basename` as well. Otherwise we end up calling `git grep -l "\n"` which would list all files containing a newline.
nickrolfe
approved these changes
Oct 10, 2022
Contributor
nickrolfe
left a comment
There was a problem hiding this comment.
That seems reasonable.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command to gather the changed files uses NULL character terminated "lines", therefore we should supply the
-zflag tobasenameas well. Otherwise we end up callinggit grep -l "\n"which would list all files containing a newline.This should fix errors on
qhelp.incfiles like in https://github.com/github/codeql/actions/runs/3214105642/jobs/5261655998 .