Only upload results if there are any#911
Merged
robertbrignull merged 1 commit intomainfrom Nov 13, 2023
Merged
Conversation
charisk
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a repeat of #853
Only call
uploadRepoResultif there are results. This function is what makes the/artifactAPI request and uploads the artifact contents to azure. So without it we only do the request that sets the repo task status to "succeeded".See the corresponding API change that makes it handle repo tasks that are succeeded without an artifact uploaded. This PR should not be merged until the API is updated.