Skip to content

Remove required permissions from jobs#820

Merged
charisk merged 1 commit intomainfrom
charisk/no-permissions
May 31, 2023
Merged

Remove required permissions from jobs#820
charisk merged 1 commit intomainfrom
charisk/no-permissions

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented May 11, 2023

These are no longer required since we're using signed auth tokens.

Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertbrignull
Copy link
Copy Markdown
Contributor

There are a few places in .github/workflows/codeql-query.yml that we reference GITHUB_TOKEN, and I think all of those can be removed. We are passing the token into the action as an env var but then we aren't actually using the token in the action, because all requests are now authenticated using the signed auth token.

I suggest we try deleting all references to GITHUB_TOKEN and then do another manual test to confirm it still works.

@robertbrignull
Copy link
Copy Markdown
Contributor

(As said on slack as well), the general approach here looks good to me. We aren't using these permissions anymore so the right thing to do is to remove the requirement for them.

Comment thread .github/workflows/codeql-query.yml
@charisk charisk force-pushed the charisk/no-permissions branch from abcbdd7 to e615c03 Compare May 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants