Remove JSON results validation for now#13
Merged
rneatherway merged 1 commit intomainfrom Sep 16, 2021
Merged
Conversation
5ce7306 to
6160b59
Compare
robertbrignull
approved these changes
Sep 13, 2021
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM assuming everything still works
I'll be honest I don't think I spotted src/json-result-generated.ts being introduced.
This is causing problems with path-problem and other query types. We can reintroduce it if we have a better schema for this but for now it's safer to be very permissive.
6160b59 to
3871ccf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing problems with path-problem and other query types. We
can reintroduce it if we have a better schema for this but for now
it's safer to be very permissive.