Skip to content

Replace warning annotation with a notice#102

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/not-a-warning
Oct 18, 2021
Merged

Replace warning annotation with a notice#102
shati-patel merged 2 commits intomainfrom
shati-patel/not-a-warning

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Oct 18, 2021

Not particularly urgent, but I've been meaning to update this: The latest version of actions-core lets you set a "notice" annotation. This seems a more appropriate way to link to the results issue than the current "⚠ warning".

Before:
image

After:
image

@shati-patel
Copy link
Copy Markdown
Contributor Author

Hmm, I have no idea where the integration test failure is coming from... Investigating 👀

@shati-patel
Copy link
Copy Markdown
Contributor Author

Integration test is also failing on main, see https://github.com/dsp-testing/qc-run2/runs/3928588858?check_suite_focus=true

@shati-patel
Copy link
Copy Markdown
Contributor Author

Unrelated problem. Re-trying now.

@shati-patel shati-patel marked this pull request as ready for review October 18, 2021 15:40
Copy link
Copy Markdown
Contributor

@rneatherway rneatherway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shati-patel shati-patel merged commit f766804 into main Oct 18, 2021
@shati-patel shati-patel deleted the shati-patel/not-a-warning branch October 18, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants