ev3dev#1026: Sound.speak does not work with double quotes

[amandaoneal]

No description provided.

[WasabiFan]

@ddemidov In ev3dev/ev3dev#1026 (comment) I suggested using https://docs.python.org/3.4/library/shlex.html#shlex.quote; see the conversation there. Thoughts?

[ddemidov]

@WasabiFan , yes, shlex should work, same as in several other places in sound.py, e.g. here:

ev3dev-lang-python/ev3dev/sound.py

Line 104 in ee75c5c

return Popen(shlex.split('/usr/bin/beep %s' % args), stdout=n)

[ddemidov]

Corection: not in the same way, since shlex.quote is also needed here. I think something like

cmd_line = '/usr/bin/espeak --stdout {0} "{1}" | /usr/bin/aplay -q'.format(espeak_opts, text)
cmd_args = [shlex.quote(a) for a in shlex.split(cmd_line)]
...
play = Popen(args, stdout=n)

(note the absence of shell=True) should work and would be consistent with the rest of the code.

[ddemidov]

Please see if using shlex would work here

[ddemidov]

Final edit:

cmd_line = ['/usr/bin/espeak', '--stdout'] + shlex.split(espeak_opts) + [shlex.quote(text)]
...
play = Popen(args, stdout=n)

seems to be more reliable and actually does work:

>>> espeak_opts='-a -b -c'
>>> text = 'Hello " world'
>>> cmd_line = ['/usr/bin/espeak', '--stdout'] + shlex.split(espeak_opts) + [shlex.quote(text)]
>>> cmd_line
['/usr/bin/espeak', '--stdout', '-a', '-b', '-c', '\'Hello " world\'']

[amandaoneal]

OK, switched over to shlex and tested on my local EV3 setup. Any verdict on if we wanted shell=True in the Popen calls?

[ddemidov]

I think shell=True is not needed if we use shlex.split(). Otherwise, looks good to me.

[dwalton76]

@amandaoneal can you drop the shell=True part? Once that is out it looks good to go. Thanks!

[dwalton76]

@amandaoneal there are some conflicts that have to be resolved before we can merge.

[amandaoneal]

Looked like the only merge conflict was that the folder 'ev3dev' got renamed 'ev3dev2'... Sigh. Should be back in good shape now.