Conversation
|
I also didn't update the gyro balancer as it appears to use the old |
|
I can update GyroBalancer, filed #414 for that one |
| import time | ||
| import evdev | ||
| from ev3dev import get_current_platform | ||
| from ev3dev2 import get_current_platform |
There was a problem hiding this comment.
Will this work as from . import get_current_platform? Could be future-name-change-proof like this.
|
|
||
| if platform == 'ev3': | ||
| from ev3dev._platform.ev3 import BUTTONS_FILENAME, EVDEV_DEVICE_NAME | ||
| from ev3dev2._platform.ev3 import BUTTONS_FILENAME, EVDEV_DEVICE_NAME |
| @@ -9,36 +9,36 @@ | |||
| from populate_arena import populate_arena | |||
| from clean_arena import clean_arena | |||
|
|
|||
| import ev3dev as ev3 | |||
There was a problem hiding this comment.
Why not just change this line to import ev3dev2 as ev3?
There was a problem hiding this comment.
Because it's no longer generic "ev3" interface... It's just the couple of utility methods we dumped into the init file. Do you have a different name suggestion?
There was a problem hiding this comment.
Ok, that is a good point. But ev3 is still shorter than ev3dev2, and ev3dev2 still contains ev3 in the name. So it is kind of not generic in the first place.
There was a problem hiding this comment.
Agreed 😆 I'll have to think about it a bit and see what I think in the morning (this 12-hour offset makes communication really weird!)
ddemidov
left a comment
There was a problem hiding this comment.
This looks good, but needs manual rebasing.
|
@WasabiFan I think we are good to go once the conflicts are resolved |
|
Just merged; it looks like tests passed, so I'm going to merge this. Thanks for the reviews, apologies I've been so slow! |
This file was missed in PR #412.
This is the batch rename operation we've been discussing for Stretch.
There are some test-related files from two years ago which don't seem to be referenced anywhere, so I decided to hold off on updating them until I knew what they were or if they were necessary. Any input on that would be appreciated.