Remove hard coded outA on port4 assumption#337
Merged
dwalton76 merged 1 commit intoev3dev:developfrom Sep 7, 2017
dwalton76:test-port4
Merged
Remove hard coded outA on port4 assumption#337dwalton76 merged 1 commit intoev3dev:developfrom dwalton76:test-port4
dwalton76 merged 1 commit intoev3dev:developfrom
dwalton76:test-port4
Conversation
Member
|
Why do we need to discover the port here? Isn't this only run from dry test data files? I must be tired... |
Collaborator
Author
|
The code assumed motor A was on port4 which isn't necessarily the case. |
Collaborator
Author
|
I'll wait until 1.0 is out and then merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issues #147