Skip to content

Added wait_until_not_moving() #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddemidov merged 2 commits into from
Jun 23, 2017
Merged

Added wait_until_not_moving() #327

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
542c24e
Added wait_until_not_moving()
dwalton76 Jun 23, 2017
a3607c7
Added wait_until_not_moving() docstring
dwalton76 Jun 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ev3dev/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,8 @@ def wait(self, cond, timeout=None):
if cond(self.state):
return True

def wait_until_not_moving(self, timeout=None):
Copy link
Copy Markdown
Member

@WasabiFan WasabiFan Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a documentation comment here so that it shows up on the docs site.

Copy link
Copy Markdown
Collaborator Author

@dwalton76 dwalton76 Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used it when solving a 5x5x5 cube which was about 9 minutes of off/on movement of three large motors and a medium motor. If it had exited early it would have caused the cube to jam up but it was smooth sailing so I think it is good to go.

I'll add a docstring to it in the morning.

return self.wait(lambda state: self.STATE_RUNNING not in state or self.STATE_STALLED in state, timeout)

def wait_until(self, s, timeout=None):
"""
Expand Down