Update motor tests to work with BrickPi#213
Update motor tests to work with BrickPi#213dwalton76 merged 2 commits intoev3dev:developfrom ddemidov:brickpi
Conversation
|
@dlech, could you please check if this still does what was intended originally? |
|
Yes. Ping me if I haven't done this in a week or two. |
ping |
|
@ddemidov two more sync conflicts have cropped up...can you take a quick look and we can get this in? |
|
I've rebased on current develop, but I can not test the changes on brickpi (don't have it). |
|
me neither mine died a while back :( @dlech can you give this a quick test and let us know if it looks good? |
| 'speed_pid': { 'kP': 1000, 'kI': 60, 'kD': 0 }, | ||
| 'hold_pid': { 'kP': 20000, 'kI': 0, 'kD': 0 }, | ||
| } | ||
| paramsA = pistorms_params |
There was a problem hiding this comment.
This should probably be paramsA = ev3_params.
|
I updated my brickpi branch with some more commits, but #152 seems to have ignored it since it is closed and it won't let me re-open. https://github.com/dlech/ev3dev-lang-python/tree/brickpi |
|
I've pulled commits from https://github.com/dlech/ev3dev-lang-python/tree/brickpi here. |
|
What's the situation here: do we want to resolve conflicts and merge? I'm happy with this if you guys believe it doesn't break anything. |
|
+1 for merging it |
|
I've just reset contents of tests/motor to that of 'brickpi' branch at dlech/ev3dev-lang-python. This narrows the PR to this particular folder and (I hope) makes sure we don't screw up other parts of the repo. |
|
I don't have a brickpi but I'll at least test out the patch tonight to make sure tests are ok on EV3 and EVB...assuming so will merge it after that. |
This resolves merge conflicts in #152.