Skip to content

[WIP] mix release support#8677

Merged
josevalim merged 55 commits intomasterfrom
jv-basic-releases
Jan 28, 2019
Merged

[WIP] mix release support#8677
josevalim merged 55 commits intomasterfrom
jv-basic-releases

Conversation

@josevalim
Copy link
Copy Markdown
Member

@josevalim josevalim commented Jan 22, 2019 •
edited
Loading

For the complete roadmap for releases, see #8612.

@josevalim josevalim mentioned this pull request Jan 22, 2019
Closed
6 tasks
@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 24, 2019

Hi everyone, this PR is feature complete for the goals it aims to achieve (for a complete roadmap see #8612). The missing parts are:

  • Windows tooling
  • Improve the test suite

This means it would be really appreciated if we start to get some reviews in. There are two ways you can help:

  1. Review the code in the PR
  2. Review the docs. The docs are all here: https://github.com/elixir-lang/elixir/pull/8677/files#diff-53c844525c23fd1a21c03113baf7e781R3

Thanks!

lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/release.ex Outdated
@lukaszsamson @josevalim
Update lib/mix/lib/mix/release.ex
c96dd35 
Co-Authored-By: josevalim <jose.valim@gmail.com>
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
lukaszsamson
lukaszsamson reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/release.ex
saulecabrera
saulecabrera reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/release.ex Outdated
sneako
sneako reviewed Jan 24, 2019
View reviewed changes
Comment thread lib/mix/lib/mix/tasks/release.ex Outdated
@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 28, 2019

Integration tests are in. It is just a matter of becoming green on Travis+Appveyor.

@eksperimental
Copy link
Copy Markdown
Contributor

eksperimental commented Jan 28, 2019

@josevalim Are you planning one merging this soon, or in the near future? I'm asking this because I'm started working on converting the bin scripts to a POSIX compliant, but I worked master. I see many of the non-POSIX compliant code have been eliminated in this PR.
So far I have only worked on bin/elixir but it's looking good.

@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 28, 2019

@eksperimental I want to merge it really soon. Regarding POSIX, CI got a bunch of failures, that's why they have been fixed. :) But I would appreciate if the new PR is based off this branch.

@eksperimental
Copy link
Copy Markdown
Contributor

eksperimental commented Jan 28, 2019

Right on. I will submit a PR once this gets merged.

@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 28, 2019

@eksperimental tests are green on travis, which means we should no longer change the script files. :)

@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 28, 2019

@eksperimental btw, if you can also review the release scripts for POSIX standards, it would be awesome. Although we should be good on this front too.

@eksperimental
Copy link
Copy Markdown
Contributor

eksperimental commented Jan 28, 2019

OK, I will do that then.

@josevalim josevalim merged commit dc03037 into master Jan 28, 2019
@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 28, 2019

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the jv-basic-releases branch January 28, 2019 20:42
eksperimental
eksperimental reviewed Jan 29, 2019
View reviewed changes
Comment thread bin/elixir
fi

set -- "$ERTS_BIN$ERL_EXEC" -pa "$SCRIPT_PATH"/../lib/*/ebin $ELIXIR_ERL_OPTIONS $ERL -extra "$@"
ERTS_BIN=""
Copy link
Copy Markdown
Contributor

@eksperimental eksperimental Jan 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERTS_BIN is not doing anything in this script, as it will always be ""

@josevalim
Copy link
Copy Markdown
Member Author

josevalim commented Jan 29, 2019 via email

@josevalim josevalim mentioned this pull request Mar 5, 2019
Closed
@gcauchon gcauchon mentioned this pull request May 15, 2019
Merged
@mracos mracos mentioned this pull request Aug 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

8 more reviewers

@wojtekmach wojtekmach wojtekmach left review comments

@bitwalker bitwalker bitwalker left review comments

@lukaszsamson lukaszsamson lukaszsamson left review comments

@saulecabrera saulecabrera saulecabrera left review comments

@AndrewDryga AndrewDryga AndrewDryga left review comments

@beardedeagle beardedeagle beardedeagle left review comments

@sneako sneako sneako left review comments

@eksperimental eksperimental eksperimental left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@josevalim @eksperimental @wojtekmach @bitwalker @lukaszsamson @saulecabrera @AndrewDryga @beardedeagle @sneako