Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

reverts to base Ruby SAML v1.15.0#11494

Merged
bramleyjl merged 0 commit intomasterfrom
50385_revert_to_base_ruby_saml
Jan 10, 2023
Merged

reverts to base Ruby SAML v1.15.0#11494
bramleyjl merged 0 commit intomasterfrom
50385_revert_to_base_ruby_saml

Conversation

@bramleyjl
Copy link
Copy Markdown
Contributor

@bramleyjl bramleyjl commented Jan 6, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

This PR reverts the Ruby-SAML gem back to the base version; vets-api had previously forked its own version to fix a bug with SAML signing, but the base version has also been updated so that is no longer necessary.

Related issue(s)

Testing done

  • Performed signed SAML logins to ensure functionality remains.

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • No error nor warning in the console.
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@bramleyjl bramleyjl added identity identity-backend Identity team backend label labels Jan 6, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to 50385_revert_to_base_ruby_saml/main/main January 6, 2023 17:15 Inactive
@bramleyjl bramleyjl marked this pull request as ready for review January 6, 2023 17:20
@bramleyjl bramleyjl requested review from a team as code owners January 6, 2023 17:20
@RachalCassity
Copy link
Copy Markdown
Member

RachalCassity commented Jan 9, 2023

Nice! Good find!

@bramleyjl bramleyjl merged commit 865d899 into master Jan 10, 2023
@bramleyjl bramleyjl deleted the 50385_revert_to_base_ruby_saml branch January 10, 2023 15:34
RachalCassity added a commit that referenced this pull request Jan 25, 2023
* VaNotify - 527ez confirmation email (#11333)

* remove hash from params (#11355)

* [11358] Updating TTL for mobile_test client for SiS (#11359)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Add feature flag for browser monitoring in Health Care application (#11361)

* API-21502: Return cached status on VBADocuments::uploads#show endpoint when status refresh fails (#11353)

* API-21502: Return cached status on VBADocuments::uploads#show when status refresh fails with an allowed exception

* API-21502: Remove unnecessary Faraday::TimeoutError rescue, improve Common::Exceptions::BadGateway exception handling specs

* API-21502: Improve Common::Exceptions::BadGateway exception handling specs

* API-21502: Update test scenario to say 'raise' instead of 'throw'

* API-21502: Update comment to say 'raise' instead of 'throw'

* API-21502: Improve comment

* Remove email address from job logs (#11357)

* Remove email address from job logs

* Update spec

* Add /v0/mhv_account to swagger doc (#11356)

* update va-home flag (#11343)

* Update personalization params (#11363)

* Clinic Patient Friendly Names Not Displaying  (#11354)

* added clinic friendly name to returned appointment attributes

* [#MHV-39388] adding feature flag for mhv secure messaging (#11366)

* Bump json from 2.6.2 to 2.6.3 (#11364)

Bumps [json](https://github.com/flori/json) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](https://github.com/flori/json/compare/v2.6.2...v2.6.3)

---
updated-dependencies:
- dependency-name: json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump mini_magick from 4.11.0 to 4.12.0 (#11365)

Bumps [mini_magick](https://github.com/minimagick/minimagick) from 4.11.0 to 4.12.0.
- [Release notes](https://github.com/minimagick/minimagick/releases)
- [Commits](https://github.com/minimagick/minimagick/compare/v4.11.0...v4.12.0)

---
updated-dependencies:
- dependency-name: mini_magick
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* API-21476: Add Logging and Metadata for Base64-Encoded VBADocuments Submissions (#11370)

* API-21476: Add logging and metadata for base64 submissions

* API-21476: Pass file instead of path to helper method (code style change only)

* API-21476: Rename 'file' to 'tempfile' (code style change only)

* API-21476: Update test description (code style change only)

* 4246 add preferred name gender identity to UserSerializer (#11287)

* fetched demographics for preferred name and gender identity

* added preferred name and gender identity to profile

* added preferred name and gender identity to rspec

* rubocop cleanup

* updated doc

* fixed gender

* updated doc profile properties

* code cleanup

* moved userstruct out of serializer

* fix

* moved struct to adapter

* fixed and updated specs

* rubocop fix

* cleanup - IP

* cleanup - IP

* cleanup and removed adapter

* Adds bgs response factory (#11362)

* Adds bgs response factory

* Adds faker, fixes typo, removes extra method

* Refactor Faker

* bump rails-html-sanitizer (#11375)

* Mhv secure messaging feature flag (#11369)

* [#MHV-39388] adding feature flag for mhv secure messaging

* [#MHV-39388] adding feature admin users for flipper UI

* Revert claim establisher (#11379)

* 4195 mobile lighthouse ccg letters (#11313)

* [22884] adds USiP logging to SiS auth & refactors applications constants (#11345)

* adds USiP logging to SiS auth & refactors applications constants

* moves USiP logging into standard SSOe log methods

* further updates

* spec cleanup

* rubocop fix

* removes unused USiP statsd codes

* adds vaweb default client_id for SSOe

* rubocop fix & USiP clients constant update

* Don't log email address when email job fails (#11382)

* Test preview environment workflow (#11380)

* Test preview environment workflow

* Test preview environment workflow

* update trigger name

Co-authored-by: Curt Bonade <cbonade@Curts-MacBook-Pro.local>

* Add environment to appeals stuck record notifications (#11381)

* Pulling DB stuff into it's own PR (#11386)

* Add backup form 526 submission path (#11317)

* Supporting form 4142 on supp claims

* Adding multiple responses

* Removing ap

* Rubocopd

* Adding multiple responses

* Refactoring and testing logging

* Refactoring

* Rubocop fixes

* Moving things around, breaking supp claims stuff into its own file to keep rubocop happy

* removing extra line

* Dont actually use this var

* Check-point I can go back to incase I wreck this with refactoring

* Refactoring

* Rubocop

* Refactoring to appease rubocop

* changing to only send the relevant part of the payload

* Adding a bit more logging to 4142 submission stuff.

* Rubocop complaining about line length

* Adding user info to log message (uuid and icn, not any any PII info)

* Adding test cases

* Moving this into the existing test case

* Removing unreliable way to determine file creation. Adding comment.

* Inital swag at this

* Adding `get_docs` methods to 2 of the EVSS service classes to just stamp and return the doc rather than do that and then send it to EVSS.

* commiting before I refactor

* Checking in

* Rubocop

* Adding in queueing of submission (with no retries)

* Getting closer

* Adding options and settings

* Accedentally commited with merge conflict

* forgot to resolve conflict

* Rubocop auto-resolve

* Rubocop manual fixing

* This needs moved up

* Fixing failing tests

* Adding tests and refactoring

* Not supporting unqueued submissions

* Additional test cases

* updating test cases for job tracker

* rubocoping

* Downcasing header

* Not actually using this

* Removed this

* Changing from flipper to a setting

* Rubocop

* Adding backup jid to log message

* rubocop

* Trying to add saving the id into this

* Adding test for update to submission id new column

* Addressing concerns

* Adding Flipper in addition to setting. If something goes horribly wrong somehow, would like to have a way to imediatly kill it.
Will remove flipper after it is fully released and confirmed stable.

* Removing these schema updates, they are from an old schema update I did for an experimental PR, that I havent figured out how to get rid of in my DB yet.

* updating comment

* Rubocop + removing comment

* rubocop

* Rubocop

* Moving db/ changes to new PR

* Mobile EVSS to Lighthouse letters benefits (#11279)

* [bug] Account for old flow FSR edge case (#11367)

* Remove PII attributes from being logged in sentry

* Account for old flow edge case

* VAOS::V2::AppointmentsController#index throwing 500 error (#11387)



* added location id check prior to calling get clinic

* Appeals status API docs fixes (#11372)

* This needs to go one layer deeper for EVSS (#11389)

* This needs to go one layer deeper for EVSS

* Need to parse out the nested payload

* Remove caregiver_mulesoft feature flag and 1010cg carma api code (#11376)

* remove carma client

* remove config

* remove carma require

* fix carma client spec

* remove carma specs

* Bump ruby-saml from `c22d6bb` to `0b38880` (#11385)

Bumps [ruby-saml](https://github.com/department-of-veterans-affairs/ruby-saml) from `c22d6bb` to `0b38880`.
- [Release notes](https://github.com/department-of-veterans-affairs/ruby-saml/releases)
- [Commits](https://github.com/department-of-veterans-affairs/ruby-saml/compare/c22d6bb9cdc6a409465692e8cca4e7bff3cb8df3...0b388803f9484e473bf3ca217ff40f822d93335a)

---
updated-dependencies:
- dependency-name: ruby-saml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sidekiq_alive from 2.1.6 to 2.1.7 (#11373)

Bumps [sidekiq_alive](https://github.com/arturictus/sidekiq_alive) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/arturictus/sidekiq_alive/releases)
- [Commits](https://github.com/arturictus/sidekiq_alive/compare/v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: sidekiq_alive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* API-20509: Retire VBADocument V0 upload_complete endpoint (#11140)

* API-22209 Fix Decision Reviews OAS documents (#11308)

* API-22209 Fix OAS errors

* 49533 remove dev lorota key from settings (#11390)

* Make COE downloads work directly (#11399)

* Set homeSellIndictor to nil (#11393)

* Certificate of Eligibility | Transform Marine Corps to Marines (#11388)

* Transform Marine Corps to Marines

* Add missing ends

* Ksoskin/fix/minor 526 backup submission fixes (#11398)

* Minor mismatch between filename check between prd and non-prod envs for file deletion

* Remove unused function

* fixing var

* Minor file change

* Fix homeSellIndicator values (#11401)

* Fix homeSellIndicator values

* Revert development.yml change

* VaNotify - 527ez update personalization params (#11394)

* Making dslogon_verified scope in sessions controller call standard dslogon authn_context (#11402)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* API-21392: Add Error Processing for VBADocuments Submissions that Consistently Time Out (#11400)

* API-21392: Add error processing for the rare upload that consistently times out when being uploaded to Central Mail Portal

* API-21392: Address rubocop 'be' vs. 'eql' feedback

* check if claimant_service returned a valid claimant_id (#11302)

* check if claimant_service returned a valid claimant_id

* rubocop fix

* convert to string of claimant id to int

* handle claimant id being nil in enrollment end point

* add field (#11403)

* Fix appeals daily stuck records report cadence (#11405)

* 4407 filter logic (#11404)

* 4407: add mobile list filter logic

* Add validate endpoint (#11331)

* Add validate endpoint

* Rename plural ITF to singular ITF

* Rename ITF support files (singular/plural)

* Bump fitbit_api from 0.14.2 to 0.15.1 (#11397)

Bumps [fitbit_api](https://github.com/zokioki/fitbit_api) from 0.14.2 to 0.15.1.
- [Release notes](https://github.com/zokioki/fitbit_api/releases)
- [Changelog](https://github.com/zokioki/fitbit_api/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zokioki/fitbit_api/compare/v0.14.2...v0.15.1)

---
updated-dependencies:
- dependency-name: fitbit_api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add GCIO VFEP to Flipper UI (Feature Toggles). (#11408)

VFEP-311 Add team emails to access Flipper UI (Feature Toggles).

* [#MHV-39815] Don't force using cache when getting the list of triage teams (#11409)

* Api 22117 email rx yaml setting file (#11342)

* API-22117 Moved report recipients from settings to in repo config files

Co-authored-by: Drew Fisher <142862+cilestin@users.noreply.github.com>

* Update modules/appeals_api/app/workers/appeals_api/daily_error_report.rb

Co-authored-by: Drew Fisher <142862+cilestin@users.noreply.github.com>

* Dried up code around getting email rxs, fixed up unit tests

* rubo!!!!

* Added nil guard, it's expected the env key we are after will be nil sometimes

* tried to make load_recipients fail_safe and add unit test around missing files and around empty key values

* Mod unit test description

* Moved load_recipients from const into perform to avoid sidekiq preloder errors

* Added unit test to simulate bad env setting

* Don't try to run reports if no recipients are configured

* Got rid of un-needed internal mock, renamed vars a little

Co-authored-by: michelpmcdonald <michel.mcdonald@adhocteam>
Co-authored-by: Drew Fisher <142862+cilestin@users.noreply.github.com>

* [11329] Refactoring MPI Service add_person_implicit_search (#11383)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Roll back openapi verison in appeals docs (#11419)

Also gets rid of unused `openapi_version` helper

* API-6969 Add monthly appeals stats report (#11319)

* API-6969 Add monthly appeals stats report

Sets up a monthly emailed report of mean/median status transition times
for appeals records

* [11425] Properly copying attributes from MPI to MHV add person call when sign in service authentication occurs (#11426)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Api 22117 retry notification (#11422)

* Added slack notification for reports that throw an exception on all of their re-run attempts

Co-authored-by: michelpmcdonald <michel.mcdonald@adhocteam>

* 50746 Deprecate CHIP 500 error map feature flag (#11413)

Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>

* pass latest param via the url (#11406)

* pass latest param via the url

* give end_point params a default value

* update claim status calls and specs

* Revert "50746 Deprecate CHIP 500 error map feature flag (#11413)" (#11435)

This reverts commit 4ea47d05b0e2cb4b6ad9158acc2d0e852713ae34.

* Schema bump (#11418)

* Schema bump

* Updating

* Add ff (#11431)

* [11347] Refactor MPI add_person_proxy (#11384)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Bump bootsnap from 1.13.0 to 1.15.0 (#11395)

* Bump bootsnap from 1.13.0 to 1.15.0

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.13.0 to 1.15.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.13.0...v1.15.0)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Reverted Gemfile.lock

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Bump aws-sdk-s3 from 1.117.1 to 1.117.2 (#11415)

* Bump aws-sdk-s3 from 1.117.1 to 1.117.2

Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby) from 1.117.1 to 1.117.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

---
updated-dependencies:
- dependency-name: aws-sdk-s3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Reverted Gemfile.lock

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Fix loan parameters sent to LGY. (#11439)

Previously, `noRestorationEntitlementIndicator` was set to true if the user selected either "an entitlement inquiry only" _OR_ "a one-time restoration of entitlement." LGY recently indicated that this was incorrect. `noRestorationEntitlementIndicator` should be true if and only if the user selects "an entitlement inquiry only."

* Transform Marine Corps and Marine Corps Reserves to Marines. (#11438)

In https://github.com/department-of-veterans-affairs/vets-api/pull/11388/, we ensured that "Marine Corps Reserve" would be transformed to "MARINES" in order to satisfy LGY's requirements.  Building atop that work, this PR ensures that "Marine Corps" is also transformed to "MARINES".

* 50746 Deprecate CHIP 500 error map feature flag (#11413) (#11437)

Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>

Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>

* Change V1 appeals status healthchecks to fit API standards (#11441)

* 50750 Deprecate Lorota delete feature flag (#11430)

Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>

* Appeals docs regeneration (#11429)

* Regenerate appeals API docs

* Update logic in appeals API docs generation

Replaces conditionals based on the :segmented_apis WIP doc setting with
conditionals based on the DocHelpers.decision_reviews? helper

* Fix shared schema inclusion in appeals docs

* Uses string instead of symbol keys to slice schema objects in rswag
  config (slices were empty previously)
* Uses symbol instead of string keys for contestable issues schemas
* Fixes incorrect API_NAME environment variable in decision reviews when
  running all appeals rswag tasks at once

* 50747 remove feature flag for synthetic metric name (#11414)

* changes inherited_proofing access_token auth to prevent method name collisions (#11436)

* update claim_status route in forms_controller (#11452)

* Update code_checks.yml (#11454)

* Bump google-apis-core from 0.9.1 to 0.9.2 (#11445)

* Bump google-apis-core from 0.9.1 to 0.9.2

Bumps [google-apis-core](https://github.com/googleapis/google-api-ruby-client) from 0.9.1 to 0.9.2.
- [Release notes](https://github.com/googleapis/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/main/google-apis-core/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-api-ruby-client/compare/google-apis-core/v0.9.1...google-apis-core/v0.9.2)

---
updated-dependencies:
- dependency-name: google-apis-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Reverted Gemfile.lock

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Add sanitized branchname to pe deploy workflow (#11428)

Co-authored-by: Curt Bonade <cbonade@Curts-MacBook-Pro.local>

* Add lighthouse-banana-peels team to pertinent spots (#11447)

* Add lighthouse-banana-peels team to pertinent spots

* Add Banana Peels team to Benefits Intake API ownership (starting to transition ownership from Caracal)

Co-authored-by: Kristen Brown <kristen.brown@adhocteam.us>

* [42310] SiS ClientConfig Profiles (#11255)

* adds new client configs

* more client config updates

* spec updates

* updates client config profile with safe hash checks

* spec fixes

* rubocop updates

* minor refactors

* adds client_config model

* build client config class methods

* updates client config to model usage

* moves client ids to auth constants file

* spec updates

* spec cleanup

* cleanups & client_config_spec addition

* client_id validations update

* client config spec refactor

* spec improvements

* restores pre-client_config validation check for client_id in handle_pre_login_error

* [11349] Refactor mpi service update_profile (#11391)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* CST DLD: Added ClaimLetter-YYYY-MM-D.pdf format filename and changed … (#11368)

* CST DLD: Added ClaimLetter-YYYY-MM-D.pdf format filename and changed how related methods raise errors.

* got rid of memoization after team discussion

* Bump json_schemer from 0.2.22 to 0.2.24 (#11444)

* Bump json_schemer from 0.2.22 to 0.2.24

Bumps [json_schemer](https://github.com/davishmcclurg/json_schemer) from 0.2.22 to 0.2.24.
- [Release notes](https://github.com/davishmcclurg/json_schemer/releases)
- [Commits](https://github.com/davishmcclurg/json_schemer/compare/v0.2.22...v0.2.24)

---
updated-dependencies:
- dependency-name: json_schemer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Reverted Gemfile.lock

* comment out lines to identify offending tests

* comment out line to identify offending tests

* uncomment offending tests

* try fix

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>
Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>

* 526 backup path uploads to pdf (#11449)

* Adding the class, need to work it in

* Adding in pdf conversion specifically for 526 backup submissions.
Also refactoring to make use of some existing File helpers rather than us my own

* Adding in untracked files

* Minor tweaks

* Adding different types of imgs for testing conversion. Adding a test case.

* comments

* Slight refactor of test

* Rubocop

* Adding in forgotten bit here

* Changing array format

* Bump rubocop-rails from 2.17.2 to 2.17.3 (#11288)

* Bump rubocop-rails from 2.17.2 to 2.17.3

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.17.2 to 2.17.3.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.2...v2.17.3)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix rubocop complaints in modules/appeals_api/spec/factories/higher_level_reviews.rb

* fix rubocop complaints in modules/appeals_api/spec/factories/notice_of_disagreements.rb

* clean up modules/appeals_api/spec/factories/notice_of_disagreements.rb

* update complaints in modules/appeals_api/spec/factories/supplemental_claims.rb

* clean up modules/appeals_api/spec/factories/supplemental_claims.rb

* update complaints in modules/claims_api/spec/factories/auto_established_claims.rb

* clean up modules/claims_api/spec/factories/auto_established_claims.rb

* fix complaints in modules/claims_api/spec/factories/power_of_attorney.rb

* clean up modules/claims_api/spec/factories/power_of_attorney.rb

* append the good 'ol to_s

* test each updated JSON.parse line and fix accordingly

* fix more cop complaints

* more

* more

* more

* more

* fix file extension typo

* fix error

* fix path

* fix path

* fix path

* fix cop offense

* try simplifying args to ::Rails.root.join

* revert previous commit

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>

* Adding icn variable to fix MPI update profile error (#11458)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Bump rubocop-rails to v2.17.4 (#11455)

* try bumping rubocop-rails to latest

* push saved Gemfile.lock

* rubocop

* fix cop complaint / remove disable cop

* Bump rubocop-rspec from 2.13.2 to 2.15.0 (#11309)

* Bump rubocop-rspec from 2.13.2 to 2.15.0

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.13.2 to 2.15.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.13.2...v2.15.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* disable cop

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>

* adds inherited_proofing to CODEOWNERS under vsp-identity (#11423)

* Fixes for appeals stats report (#11456)

* Format appeals stats report email as HTML

* Use dedicated config file for appeals stats report recipients

* Bump redis-namespace from 1.9.0 to 1.10.0 (#11463)

Bumps [redis-namespace](https://github.com/resque/redis-namespace) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/resque/redis-namespace/releases)
- [Changelog](https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md)
- [Commits](https://github.com/resque/redis-namespace/compare/v1.9...v1.10.0)

---
updated-dependencies:
- dependency-name: redis-namespace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump aws-sdk-kms from 1.60.0 to 1.61.0 (#11462)

Bumps [aws-sdk-kms](https://github.com/aws/aws-sdk-ruby) from 1.60.0 to 1.61.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-kms/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.60.0...v1.61.0)

---
updated-dependencies:
- dependency-name: aws-sdk-kms
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump coverband from 5.2.4 to 5.2.5 (#11461)

Bumps [coverband](https://github.com/danmayer/coverband) from 5.2.4 to 5.2.5.
- [Release notes](https://github.com/danmayer/coverband/releases)
- [Changelog](https://github.com/danmayer/coverband/blob/main/changes.md)
- [Commits](https://github.com/danmayer/coverband/commits/v5.2.5)

---
updated-dependencies:
- dependency-name: coverband
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sidekiq_alive from 2.1.7 to 2.1.8 (#11460)

Bumps [sidekiq_alive](https://github.com/arturictus/sidekiq_alive) from 2.1.7 to 2.1.8.
- [Release notes](https://github.com/arturictus/sidekiq_alive/releases)
- [Commits](https://github.com/arturictus/sidekiq_alive/compare/v2.1.7...v2.1.8)

---
updated-dependencies:
- dependency-name: sidekiq_alive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* removes status in response (#11459)

* Add Kyle Soskin to production daily report email (#11457)

* Bump mail from 2.7.1 to 2.8.0 (#11396)

* Bump mail from 2.7.1 to 2.8.0

Bumps [mail](https://github.com/mikel/mail) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/mikel/mail/releases)
- [Changelog](https://github.com/mikel/mail/blob/2.8.0/CHANGELOG.rdoc)
- [Commits](https://github.com/mikel/mail/compare/2.7.1...2.8.0)

---
updated-dependencies:
- dependency-name: mail
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* remove useless test

* retain some of the previously removed test

* retain more of test

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>

* Vfep 56 final - remove employment from spool files form 5490 (#11446)

* VFEP-56 5490 spool file remove employment

* gemfile.lock

* update gemfile.lock

Co-authored-by: rccassity <rccassity@gmail.com>

* Encrypt form arguments in HCA submission jobs (#11416)

* add encrypted submission jobs

* decrypt form in failure block

* add anon encrypted submission job spec

* use encrypted job in hca model

* 50749 remove specs related to ssn (#11443)

* 4409 filter validation (#11466)

* 4409: list filter validations

* adds logging around service build (#11470)

* API 21584 Add get ITF by type endpoint (#11411)

* Add method to supply itf types

* Move logic to check invalid type parameter

* Add comment, fix rubocop line length offense

* Change ITF type burial to survivor

* Fix rspec test for changed ITF type

* Remove extraneous comma

* Add model for v2, update controller

* Revert change to submit method

* Rubocop whitespace corrections

* Handle upper/mixed case to match validation, add tests

* Use keys from existing constant for itf types, remove method

* rework controller

* rework blueprinter

* add initializer to keep order

* appease the rubocop king

* Fix test to accommodate response format change

* Revert addition of data to response, revert related test change

* Update v2 schema to match updated response structure

Co-authored-by: FonzMP <fonzmp@gmail.com>

* Api 22541 update 5103 description (#11412)

* Inherited Proofing Audit Data Validations (#11421)

* adds inherited proofing AuditData class for callback validation of auth code

* adds audit_data specs

* spec cleanups

* further cleanups

* adds audit_data unit spec

* Bump rubocop-rspec from 2.15.0 to 2.16.0 (#11477)

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.15.0 to 2.16.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.15.0...v2.16.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding forms documentation (#11482)

* Adding forms documentation

* Adding forms documentation

Co-authored-by: mviterna <mark.viterna@gmail.com>

* removes redundant identity_proofed? method (#11479)

* Refactor rake tasks for Appeals docs (#11469)

In preparation for API-21523, this refactors the Rakefile used to
generate Appeals API docs with the following goals:
* Make it harder to forget to generate dev docs:
   * Each API now has its own 'all' task, which runs the 'dev' and
     'prod' tasks at once.
   * The general 'all' task now builds all prod and all dev docs for all
     APIs (not just prod docs).
* Make it easier to add docs for new APIs later:
  * Until now, an absent ENV['API_NAME'] in docs specs meant that we
     were building the aggregate decision reviews docs (as opposed to a
     segmented doc).
  * These changes make it so that ENV['API_NAME'] is never unset -
    instead, 'decision_reviews' is used as the API name for decision
    reviews. This makes configs a little simpler and more consistent.

* Revert "Bump mail from 2.7.1 to 2.8.0 (#11396)" (#11484)

This reverts commit 187aa2edeecff73f9c7041ce442c9778363effe6.

* Bump jwt from 2.5.0 to 2.6.0 (#11473)

Bumps [jwt](https://github.com/jwt/ruby-jwt) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/jwt/ruby-jwt/releases)
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.5.0...v2.6.0)

---
updated-dependencies:
- dependency-name: jwt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump statsd-instrument from 3.5.0 to 3.5.2 (#11491)

Bumps [statsd-instrument](https://github.com/Shopify/statsd-instrument) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/Shopify/statsd-instrument/releases)
- [Changelog](https://github.com/Shopify/statsd-instrument/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/statsd-instrument/compare/v3.5.0...v3.5.2)

---
updated-dependencies:
- dependency-name: statsd-instrument
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lockbox from 1.1.0 to 1.1.1 (#11490)

Bumps [lockbox](https://github.com/ankane/lockbox) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/ankane/lockbox/releases)
- [Changelog](https://github.com/ankane/lockbox/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/lockbox/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: lockbox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google-apis-core from 0.9.2 to 0.9.3 (#11475)

Bumps [google-apis-core](https://github.com/googleapis/google-api-ruby-client) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/googleapis/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/main/google-apis-core/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-api-ruby-client/compare/google-apis-core/v0.9.2...google-apis-core/v0.9.3)

---
updated-dependencies:
- dependency-name: google-apis-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump simplecov from 0.21.2 to 0.22.0 (#11476)

Bumps [simplecov](https://github.com/simplecov-ruby/simplecov) from 0.21.2 to 0.22.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases)
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md)
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.21.2...v0.22.0)

---
updated-dependencies:
- dependency-name: simplecov
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 51340 remove ssn4 code (#11485)

* 51340 initial commit

* 51340 fix specs

* Remove PACT Broker Support (#11493)

* Remove Pact State Generator

Reverts https://github.com/department-of-veterans-affairs/vets-api/pull/4940

* Remove Makefile references to PACT

* Remove spec service consumers

* Remove unused stub_session helper

* Remove misc spec file mentions of pact

* Remove GHA for pact

* Remove pact references from Gemfile and Rakefile

* Remove unnecessary Rubocop disable

* Ignore CVE-2022-46648 (#11508)

* Ignore CVE-2022-46648

* Removed old CVE

Co-authored-by: rccassity <rccassity@gmail.com>

* update prod oas (#11507)

* Bump strong_migrations from 1.4.0 to 1.4.1 (#11503)

* Bump strong_migrations from 1.4.0 to 1.4.1

Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: strong_migrations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Revert sidekiq

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Bump google-protobuf from 3.21.9 to 3.21.12 (#11502)

* Bump google-protobuf from 3.21.9 to 3.21.12

Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 3.21.9 to 3.21.12.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.21.9...v3.21.12)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Revert sidekiq

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Bump google-apis-generator from 0.11.0 to 0.11.1 (#11501)

* Bump google-apis-generator from 0.11.0 to 0.11.1

Bumps [google-apis-generator](https://github.com/googleapis/google-api-ruby-client) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/googleapis/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/main/google-apis-generator/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-api-ruby-client/compare/google-apis-generator/v0.11.0...google-apis-generator/v0.11.1)

---
updated-dependencies:
- dependency-name: google-apis-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Revert sidekiq

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* Bump puma from 6.0.0 to 6.0.2 (#11500)

* Bump puma from 6.0.0 to 6.0.2

Bumps [puma](https://github.com/puma/puma) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v6.0.0...v6.0.2)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Revert sidekiq

* Revert sidekiq

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rccassity <rccassity@gmail.com>

* [11348] Refactoring the MPI find_profile service function so that it takes discrete attributes in a series of relevant functions rather than implicitly determines what attributes to use based off of a UserIdentity object (#11442)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Adding new settings for Lighthouse Benefits Claims API (#11481)

* Adding new settings for Lighthouse Benefits Claims API

* Adding 'access_token' object under Lighthouse.settings.benefits_claims

* [11348] Adding temporary string status for MPI response until MPI cache has cycled (#11513)

* [#MHV-40133] Added "triage_group_name" passthrough from MHV SM APIs (#11497)

* [#MHV-40133] Added triage_group_name and proxy_sender_name to message model

* [#MHV-40133] Updated API docs

* [#MHV-40133] Updated spec test for Message model

* [#MHV-40133] Adding the new fields to mobile serializer, per mobile team's recommendation

* reverts to base Ruby SAML v1.15.0 (#11494)

* [11348] Adding various MPI errors requires that were causing some weird intermittent staging errors (#11514)

* DHP 477 Registration flow for users without ICN (#11472)

* DHP-477 Create test user without ICN

* DHP-477 Add expectations for :connection_available

* DHP-477 Sets connection_available bool based on presence of current_user.icn

* DHP-477 Update connection_available to connectionAvailable

* DHP-477 Tests expect 403 response when user missing icn

* DHP-477 Checks for icn before each action

* DHP-477 WIP test for users without ICN

* DHP-477 Fix tests for connection unavailable for veterans without ICN

Co-authored-by: Cam Bui <cam.bui@thoughtworks.com>

* DHP-477 Log warning to sentry for Veterans with invalid ICN value

Co-authored-by: Cam Bui <cam.bui@thoughtworks.com>

* DHP-477 Fix rubocop offenses
Co-authored-by: Yoni Doron-Peters <jonathan.d@thoughtworks.com>

* DHP-477 Fix rubocop offenses

Co-authored-by: Yoni Doron-Peter <jonathan.d@thoughtworks.com>

* Update modules/dhp_connected_devices/app/controllers/dhp_connected_devices/veteran_device_records_controller.rb

Co-authored-by: Yoni Doron-Peters <jonathan.d@thoughtworks.com>

* DHP-477 Stylist changes to methods for readability

Co-authored-by: Yoni Doron-Peters <jonathan.d@thoughtworks.com>

* DHP-477 streamline raising error

Co-authored-by: Yoni Doron-Peters <jonathan.d@thoughtworks.com>

* 4484 coerce filter values (#11506)

* 4484: coerce filter values into appropriate types

* API-22384 Adds logging of ICN for MPI troubleshooting (#11360)

* Adds logging of ICN for MPI troubleshooting

* Corrects value added to logs

* Adds icn to logger

* Adds catch

* Adds additional catches

* Rubocop

* Refactor

* Refactorx3

* Adds safe operator, and refactors for nil protection

* Removes extra log append

* PR comments addressed

* Removes sleep 10

* Adding claimDate to get_pdf call for backup 526 Submission (#11505)

* Adding claimDate to get_pdf call for backup 526 Submission

* Removing ap

* Breaking this out to appease rubocop

* Comments

* Rubocop

* Adding support to enqueue supp claims uploads (#11433)

* Adding support to enqueue supp claims uploads

* Rubocop

* Refactoring to appease rubocop

* Trying to fix test cases

* Removing ap

* Removing old require

* rubocoping

* Slight refactor

* Rubocop

* Fixing arg var name

* Need to call the class method here, not the instance method

* Rubocop

* Test cases

* Dont need this, was just using it to track statsd changes

* Moving around to appease rubocop module line requirement

* Moving constants into own file where possible

* Reducing scope to DRv1 module

* Rubocop

* var bug

* Removing chars to appease rubocop

* Adding resuce then a bunch of moving stuff around becuase rubocop made me.

* Removing loggin user info. I dont think it is PII, but do no NEED to log it.

* Removing user loggin info

* Moving file to align with module name better

* Removing space

* [11529] Preferring MPI query by credential uuid for sign in service authentication (#11530)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [va-virtual-agent#758] remove unused toggle and related dead code paths (#11519)

* [#770] remove unused toggle and related dead code paths

* remove test for removed worker file

* removes the feature toggle from config

Co-authored-by: Holden Hinkle <holden@holdenhinkle.com>

* Remove rrd_mas_disability_tracking and rrd_mas_notification toggles (#11510)

* Remove rrd_mas_disability_tracking and rrd_mas_notification toggles

* Remove some more dead code

* Remove dead test

* Upgrade RuboCop to 1.43.0 (#11524)

* Apply group labeling to /vaos/v1/locations/xxxxx/clinics endpoints for Grafana (#11480)

* added grafana grouping for vaos v1 locations clinics endpoint

* Bump ox from 2.14.11 to 2.14.12 (#11517)

Bumps [ox](https://github.com/ohler55/ox) from 2.14.11 to 2.14.12.
- [Release notes](https://github.com/ohler55/ox/releases)
- [Changelog](https://github.com/ohler55/ox/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/ox/compare/v2.14.11...v2.14.12)

---
updated-dependencies:
- dependency-name: ox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump GHA bundler cache for 2.7 (#11540)

* Updating so it's impossible to have _debug in prod (#11539)

* Updating so it's impossible to have _debug in prod

Also added logging to catch strange case we are seeing .

* Update push_notifications_controller.rb

* add `include` and `included` parameters to mobile appointment index docs (#11499)

* 51475 Enforce LGY document ownership (#11478)

- This PR validates that LGY documents requested by the user, belong to the user. Such validation does not exist on LGY's end. Before this PR, any logged-in vet could access any other vets' LGY documents.
- This PR also standardizes the EDIPIs and ICNs in our document-related VCR cassettes to accommodate changes to lgy_service.

* [11535] Updating proper error response when MPI find_by_attributes is invoked and no user is found (#11536)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Split RuboCop Enables to separate file (#11525)

* Split RuboCop enables to a separate file

* Update rubocop todo

* RuboCop: Fix 'AllowedPatterns' warning (#11528)

* Chore: Enable sidekiq metrics for datadog (#11511)

* Chore: Enable sidekiq metrics for datadog

* Chore: Collect historical metrics

* Revert previous commit

* Chore: Update gemfile lock

* Updated Gemfile.lock and allow datadog/statsd in development

Co-authored-by: rccassity <rccassity@gmail.com>

* API-22952 - Fix appeals status API tags (#11533)

The inconsistency in these tag names made the docs render incorrectly
[here](https://developer.va.gov/explore/appeals/docs/appeals): two
separate sections (one empty) were being created for the differing tag
names - there should only be one. This fixes that and also converts the
single tag to title case, which is consistent with tags in other appeals
APIs.

* Enable pending cops; Ignore with todo (#11526)

- Also removes some unnecessary cop disables

* Chore: Add dogstatsd line (#11543)

* Chore: Add dogstatsd line

* fixed syntax

Co-authored-by: rccassity <rccassity@gmail.com>

* Bump git from 1.11.0 to 1.13.0 (#11512)

Bumps [git](https://github.com/ruby-git/ruby-git) from 1.11.0 to 1.13.0.
- [Release notes](https://github.com/ruby-git/ruby-git/releases)
- [Changelog](https://github.com/ruby-git/ruby-git/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ruby-git/ruby-git/compare/v1.11.0...v1.13.0)

---
updated-dependencies:
- dependency-name: git
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Do not enable datadog statsd in other environments besides dev (#11547)

Co-authored-by: rccassity <rccassity@gmail.com>

* Fixed vsp_environment spelling (#11549)

Co-authored-by: rccassity <rccassity@gmail.com>

* [11111] Removing accounts table reference in TUD component (#11483)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* API-22759: Remove Team Caracal from Benefits Intake API CODEOWNERS entries (#11538)

* Api 21582 submit ITF (#11432)

* Add method to supply itf types

* Move logic to check invalid type parameter

* Add comment, fix rubocop line length offense

* Change ITF type burial to survivor

* Fix rspec test for changed ITF type

* Remove extraneous comma

* Add model for v2, update controller

* Revert change to submit method

* Rubocop whitespace corrections

* Remove duplicate types list

* Update field after merge

* Fix line break

Co-authored-by: Matt Christianson <matthew.christianson1@va.gov>
Co-authored-by: Austin Covrig <austin.covrig@oddball.io>

* Bump google-cloud-bigquery from 1.39.0 to 1.41.0 (#11515)

Bumps [google-cloud-bigquery](https://github.com/googleapis/google-cloud-ruby) from 1.39.0 to 1.41.0.
- [Release notes](https://github.com/googleapis/google-cloud-ruby/releases)
- [Changelog](https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-document_ai-v1beta3/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-cloud-ruby/compare/google-cloud-bigquery/v1.39.0...google-cloud-bigquery/v1.41.0)

---
updated-dependencies:
- dependency-name: google-cloud-bigquery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump spring from 4.1.0 to 4.1.1 (#11516)

Bumps [spring](https://github.com/rails/spring) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/rails/spring/releases)
- [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rails/spring/compare/v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: spring
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump faker from 3.0.0 to 3.1.0 (#11518)

Bumps [faker](https://github.com/faker-ruby/faker) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump aws-sdk-sns from 1.56.0 to 1.57.0 (#11553)

Bumps [aws-sdk-sns](https://github.com/aws/aws-sdk-ruby) from 1.56.0 to 1.57.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-sns/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.56.0...v1.57.0)

---
updated-dependencies:
- dependency-name: aws-sdk-sns
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix app name issue (#11555)

Replace bad boolean evaluation with string comparison

* Adds completed dates for each phase. (#11440)

* Adds method to add completed dates for each phase.

* Corrects factories, and methods, tests due to erroneous factory

* Fixes rswag, tests, factories

* Addresses PR comment

* Incorporates PR recommendations

* Refactors tests, and their erroneous data

* Removes comment

* [11550] Checking UserIdentity as well as User models when User redis is refreshed (#11551)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [11306] Remove Notifications and DismissedStatuses (#11307)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* Bump google-apis-core from 0.9.3 to 0.9.5 (#11568)

Bumps [google-apis-core](https://github.com/googleapis/google-api-ruby-client) from 0.9.3 to 0.9.5.
- [Release notes](https://github.com/googleapis/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/main/google-apis-core/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-api-ruby-client/compare/google-apis-core/v0.9.3...google-apis-core/v0.9.5)

---
updated-dependencies:
- dependency-name: google-apis-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Make Eugene flipper admin. (#11545)

... in advance of COE pilot launch.

* Bump nokogiri from 1.13.10 to 1.14.0 (#11567)

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.10 to 1.14.0.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.10...v1.14.0)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pundit from 2.2.0 to 2.3.0 (#11554)

Bumps [pundit](https://github.com/varvet/pundit) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/varvet/pundit/releases)
- [Changelog](https://github.com/varvet/pundit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/varvet/pundit/compare/v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: pundit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Backup submission bugfix (#11569)

* This didnt come up in testing because this is mocked to a local file locally instead of from AWS

* Pull file and return path to it

* Pull upload files right away

* Rubocop

* Need to write file as is in binary mode

* Want to be able to call loading the docs without the sending part

* API-21523 Convert appeals status v1 docs to RSwag (#11534)

This adds a new set of rswag specs for v1 of the appeals status API.
The generated JSON replaces the existing `appeals_status.yml` swagger
file. The docs for v0 remain unchanged.

* Update appeals mailing list members (#11562)

* Update appeals mailing list members

* Correct some existing email addresses in appeals lists

* Remove unused appeals settings

* Bump parallel_tests from 4.0.0 to 4.1.0 (#11578)

Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: parallel_tests
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google-cloud-bigquery from 1.41.0 to 1.42.0 (#11576)

Bumps [google-cloud-bigquery](https://github.com/googleapis/google-cloud-ruby) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/googleapis/google-cloud-ruby/releases)
- [Changelog](https://github.com/googleapis/google-cloud-ruby/blob/main/google-cloud-document_ai-v1beta3/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-cloud-ruby/compare/google-cloud-bigquery/v1.41.0...google-cloud-bigquery/v1.42.0)

---
updated-dependencies:
- dependency-name: google-cloud-bigquery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rubocop-rspec from 2.16.0 to 2.18.0 (#11580)

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.16.0 to 2.18.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.16.0...v2.18.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 43195 Merge CC Provider Info Into Appointment Response (#11322)

*provider info lookup/merge into appointments body

* Replace LH appeals_api unmaintained FastJsonapi Serializer with maintained fork JSONAPI::Serializer (#11464)

* Replace LH appeals_api unmaintained FastJsonapi Seralizer with maintained fork JSONAPI::Serializer

Co-authored-by: michelpmcdonald <michel.mcdonald@adhocteam>

* 45359 remove EVSS create user account (#11498)

* remove EVSS create user account

* further removals

* typo fix

* Revert "Bump rubocop-rspec from 2.16.0 to 2.18.0 (#11580)" (#11582)

This reverts commit 28d9468c4f835dbac7a577a1604f7d43a683863c.

* [11427] Updating specs for attribute validator file to prevent untested MPI interactions (#11467)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* rubocop fix (#11583)

* API-22867-Adds encryption to auth headers (#11496)

* Adds encryption to auth headers

* Removes the passing, and logging of PII

* Refactors

* removes extra param

* Addresses PR comments

* Add nil catch

* cleanup

* rubocop

* Addresses PR comment, and fixes a skipped test.

* Removes nil catch for user based on feedback

* Removes return in flash updater

* API-22828-close-date-cst (#11571)

* Adds closed Date to claims by id/show

* Makes it close date, rather than closed date

* Removes extra factory

* Rubocop

* Bump rails from 6.1.7 to 6.1.7.1 (#11585)

Bumps [rails](https://github.com/rails/rails) from 6.1.7 to 6.1.7.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/compare/v6.1.7...v6.1.7.1)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sidekiq_alive from 2.1.8 to 2.1.9 (#11586)

Bumps [sidekiq_alive](https://github.com/arturictus/sidekiq_alive) from 2.1.8 to 2.1.9.
- [Release notes](https://github.com/arturictus/sidekiq_alive/releases)
- [Commits](https://github.com/arturictus/sidekiq_alive/compare/v2.1.8...v2.1.9)

---
updated-dependencies:
- dependency-name: sidekiq_alive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ox from 2.14.12 to 2.14.13 (#11587)

Bumps [ox](https://github.com/ohler55/ox) from 2.14.12 to 2.14.13.
- [Release notes](https://github.com/ohler55/ox/releases)
- [Changelog](https://github.com/ohler55/ox/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/ox/compare/v2.14.12...v2.14.13)

---
updated-dependencies:
- dependency-name: ox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix buggy rswag rake tasks (#11590)

Recent updates to the appeals_api rake tasks included expectations that
certain environment variables would be set every time the config was
loaded. These variables are not set when running unrelated rswag tasks
for the Claims API, and rake was erroring when loading the Appeals
configs in this case. These changes update the appeals api configs so
that they can be loaded successfully without the expected environment
variables.

* Api 22829 claim status mapping (#11579)

* Adds method to add completed dates for each phase.

* Corrects factories, and methods, tests due to erroneous factory

* Fixes rswag, tests, factories

* Addresses PR comment

* Add test for BGSClaimStatusMapper

* Add BGS phase, tests for mapper and claim request

* Rubocop adjustments

Co-authored-by: Jennica Stiehl <25069483+stiehlrod@users.noreply.github.com>

* adds vaweb & vamobile client_ids (#11541)

* [11468] Remove historical icns MPI query (#11471)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [11531] Removing MPI checks for string 'OK' status that was temporarily added for redis compatibility (#11532)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [11306] Migration to drop table notifications (#11489)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [51829] Credential Email Schema (#11559)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* [51828] Creating schema for UserAcceptableVerifiedCredential table (#11561)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

* API-22759: Update Benefits Intake Email Report Recipients (Includes Refactoring) (#11557)

* API-22759: Initial updates to Benefits Intake report recipients (transfer to Team Banana Peels)

* API-22759: Update Benefits Intake report recipients to Team Banana Peels

* API-22759: Refactor .fetch_recipients and pull Slack alert email from settings instead of YAML

* API-22759: Add specs for .fetch_recipients for each report mailer

* API-22759: Add more recipients to VBADocuments report emails

* API-22759: Only send Slack report emails if the Slack setting is enabled on the environment

* API-22759: Fix Rubocop offenses

* API-22759: Fix Rubocop offense

* API-22759: Finish fixtures move refactor

* API-22759: Add report recipient specs for dev environment

* Bump rack from 2.2.5 to 2.2.6.2 (#11596)

Bumps [rack](https://github.com/rack/rack) from 2.2.5 to 2.2.6.2.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/v2.2.5...v2.2.6.2)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump aws-sdk-sns from 1.57.0 to 1.58.0 (#11597)

Bumps [aws-sdk-sns](https://github.com/aws/aws-sdk-ruby) from 1.57.0 to 1.58.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-sns/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.57.0...v1.58.0)

---
updated-dependencies:
- dependency-name: aws-sdk-sns
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Si…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants