refactor: port config-conventional to ts#3881
Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom Jan 30, 2024
Merged
refactor: port config-conventional to ts#3881escapedcat merged 2 commits intoconventional-changelog:masterfrom
escapedcat merged 2 commits intoconventional-changelog:masterfrom
Conversation
Member
|
Thanks! |
| "name": "@commitlint/config-conventional", | ||
| "version": "18.6.0", | ||
| "description": "Shareable commitlint config enforcing conventional commits", | ||
| "main": "lib/index.js", |
There was a problem hiding this comment.
@escapedcat, @Mersho: That change breaks ESM and CommonJS usage of '@commitlint/config-conventional':
- the generated file is ESM, but the documentation is using CommonJS syntax
- repo defaulting to ESM can't import: no properly filled
exportsfield in package.json
Replacing it by:
"exports": {
".": {
"types": "./lib/index.d.ts",
"require": "./lib/index.js",
"import": "./lib/index.js"
}
}makes things better for ESM but still breaks CommonJS: the dependency code expected syntax is in CommonJS and its default syntax for exported files is ESM ...
Please generate exported files according to the default syntax chosen, CommonJS, and then wrap to ESM, and then use exports field only in package.json.
There was a problem hiding this comment.
Breaking change for converntional-commits cli: #3909
Contributor
There was a problem hiding this comment.
@jerome-benoit can I ask you for a review on #3911? 🙏
Member
|
@Mersho can you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.