Fixing compilation after platform update#44
Merged
VISTALL merged 1 commit intoconsulo:masterfrom Apr 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Python plugin code to compile against the updated platform APIs (localization + read-action requirements), while keeping behavior the same.
Changes:
- Migrate live template macros’
getPresentableName()to returnLocalizeValueand add@RequiredReadActionwhere PSI is accessed. - Update exit-point highlighting handler to use
CodeInsightLocalizeand add@RequiredReadActionannotations. - Apply minor modernization/formatting (e.g., generics diamond, pattern matching
instanceof).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python-impl/src/main/java/com/jetbrains/python/impl/codeInsight/liveTemplates/PyFunctionNameMacro.java | Switch presentable name to LocalizeValue + mark PSI read access with @RequiredReadAction. |
| python-impl/src/main/java/com/jetbrains/python/impl/codeInsight/liveTemplates/PyClassNameMacro.java | Same platform API updates as function macro, plus formatting. |
| python-impl/src/main/java/com/jetbrains/python/impl/codeInsight/liveTemplates/CollectionElementNameMacro.java | Switch presentable name to LocalizeValue, add overrides, and modernize collections usage. |
| python-impl/src/main/java/com/jetbrains/python/impl/codeInsight/highlighting/PyHighlightExitPointsHandler.java | Replace CodeInsightBundle usage with CodeInsightLocalize and add read-action annotations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+52
to
+56
| @Override | ||
| public Result calculateResult(Expression[] params, ExpressionContext context) { | ||
| if (params.length != 1) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
calculateResult can return null (e.g., when params.length != 1 or paramResult == null), but the override isn't annotated as nullable. Consider adding @Nullable (and importing it if needed) to match the other macros in this package and keep nullability analysis accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.