Skip to content

Replacing consulo.ide.impl.idea.openapi.vfs.VfsUtil with consulo.virtualFileSystem.util.VirtualFileUtil. Replacing consulo.ide.impl.idea.openapi.util.io.FileUtil with consulo.util.io.FileUtil#43

Merged
VISTALL merged 1 commit intoconsulo:masterfrom
unv-unv:eliminating-vfs-util
Apr 18, 2026

Conversation

@unv-unv
Copy link
Copy Markdown
Contributor

@unv-unv unv-unv commented Apr 18, 2026

No description provided.

…ualFileSystem.util.VirtualFileUtil. Replacing consulo.ide.impl.idea.openapi.util.io.FileUtil with consulo.util.io.FileUtil.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces usages of IntelliJ-platform VfsUtil/VfsUtilCore and the old IDEA FileUtil implementation with Consulo’s VirtualFileUtil and consulo.util.io.FileUtil, reducing reliance on consulo.ide.impl.idea.* internals and aligning file/VFS access with the Consulo API.

Changes:

  • Replaced VfsUtil.loadText / VfsUtilCore.getRelativePath / VfsUtilCore.visitChildrenRecursively with VirtualFileUtil equivalents across production and test code.
  • Replaced IDEA FileUtil.copy/ensureCanCreateFile calls with consulo.util.io.FileUtil (including explicit permission copier for file copy on Windows).
  • Minor related API alignment: ApplicationManager.getApplication()Application.get(), SystemInfo.isWindowsPlatform.current().os().isWindows(), and bundle message → PyLocalize.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
python-impl/src/main/java/consulo/python/buildout/module/extension/BuildoutModuleExtension.java Switches script/site.py text loading to VirtualFileUtil.loadText.
python-impl/src/main/java/com/jetbrains/python/impl/run/PyVirtualEnvReader.java Uses consulo.util.io.FileUtil for temp file copy/append and adds FilePermissionCopier.
python-impl/src/main/java/com/jetbrains/python/impl/psi/impl/PyFileImpl.java Uses VirtualFileUtil.getRelativePath instead of VfsUtilCore.
python-impl/src/main/java/com/jetbrains/python/impl/packaging/PyPackageUtil.java Migrates VFS traversal/relative path to VirtualFileUtil, updates progress text localization, and switches to Application.get().
python-impl/src/main/java/com/jetbrains/python/impl/packaging/PyPackageManagerImpl.java Uses consulo.util.io.FileUtil.ensureCanCreateFile and Platform for Windows detection.
python-impl/src/main/java/com/jetbrains/python/impl/buildout/BuildoutFacet.java Updates commented-out legacy code snippets to refer to VirtualFileUtil.loadText.
plugin/src/test/java_/com/jetbrains/python/refactoring/PyCodeFragmentTest.java Updates test data file loading to VirtualFileUtil.loadText.
plugin/src/test/java_/com/jetbrains/python/fixtures/PyResolveTestCase.java Updates test file loading to VirtualFileUtil.loadText and adjusts imports.
plugin/src/test/java_/com/jetbrains/python/fixtures/LightMarkedTestCase.java Updates test file loading to VirtualFileUtil.loadText and adjusts imports/order.
plugin/src/test/java_/com/jetbrains/python/PyQuickDocTest.java Updates HTML baseline loading to VirtualFileUtil.loadText and adjusts imports.
plugin/src/test/java_/com/jetbrains/python/PyControlFlowBuilderTest.java Updates control flow golden file loading to VirtualFileUtil.loadText.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VISTALL VISTALL merged commit 9500596 into consulo:master Apr 18, 2026
5 checks passed
@unv-unv unv-unv deleted the eliminating-vfs-util branch April 18, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants