Skip to content

Replacing setTextValue → setText, setText2Value → setText2, setDescriptionValue → setDescription #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 1 commit into from
Apr 7, 2026
Merged

Replacing setTextValue → setText, setText2Value → setText2, setDescriptionValue → setDescription #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python-impl/src/main/java/com/jetbrains/python/impl/console/PydevConsoleRunnerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public void runSync() {
ProgressManager.getInstance().run(new Task.Backgroundable(myProject, LocalizeValue.localizeTODO("Connecting to Console"), false) {
@Override
public void run(ProgressIndicator indicator) {
indicator.setTextValue(LocalizeValue.localizeTODO("Connecting to console..."));
indicator.setText(LocalizeValue.localizeTODO("Connecting to console..."));
connect(myStatementsToExecute);
}
});
Expand All @@ -272,7 +272,7 @@ public void run() {
new Task.Backgroundable(myProject, LocalizeValue.localizeTODO("Connecting to Console"), false) {
@Override
public void run(ProgressIndicator indicator) {
indicator.setTextValue(LocalizeValue.localizeTODO("Connecting to console..."));
indicator.setText(LocalizeValue.localizeTODO("Connecting to console..."));
try {
initAndRun();
connect(myStatementsToExecute);
Expand Down
2 changes: 1 addition & 1 deletion ...-impl/src/main/java/com/jetbrains/python/impl/console/PythonDebugLanguageConsoleView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public PythonDebugLanguageConsoleView(Project project, Sdk sdk, ConsoleView cons
enableConsole(!PyConsoleOptions.getInstance(project).isShowDebugConsoleByDefault());

getSwitchConsoleActionPresentation().setIcon(ExecutionIconGroup.console());
getSwitchConsoleActionPresentation().setTextValue(PyLocalize.runConfigurationShowCommandLineActionName());
getSwitchConsoleActionPresentation().setText(PyLocalize.runConfigurationShowCommandLineActionName());
}

public PythonDebugLanguageConsoleView(Project project, Sdk sdk) {
Expand Down
2 changes: 1 addition & 1 deletion python-impl/src/main/java/com/jetbrains/python/impl/debugger/PyDebugProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ protected void waitForConnection(final LocalizeValue connectionMessage, Localize
ProgressManager.getInstance().run(new Task.Backgroundable(getSession().getProject(), connectionTitle, false) {
@Override
public void run(ProgressIndicator indicator) {
indicator.setTextValue(connectionMessage);
indicator.setText(connectionMessage);
try {
beforeConnect();
myWaitingForConnection = true;
Expand Down
2 changes: 1 addition & 1 deletion ...n-impl/src/main/java/com/jetbrains/python/impl/packaging/setupPy/CreateSetupPyAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public class CreateSetupPyAction extends CreateFromTemplateAction {

public CreateSetupPyAction() {
super(FileTemplateManager.getDefaultInstance().getInternalTemplate("Setup Script"));
getTemplatePresentation().setTextValue(LocalizeValue.localizeTODO("Create setup.py"));
getTemplatePresentation().setText(LocalizeValue.localizeTODO("Create setup.py"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion python-impl/src/main/java/com/jetbrains/python/impl/sdk/AbstractCreateVirtualEnvDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public void createVirtualEnv(VirtualEnvCallback callback) {
@Override
public void run(ProgressIndicator indicator) {
try {
indicator.setTextValue(PyLocalize.sdkCreateVenvDialogCreatingVenv());
indicator.setText(PyLocalize.sdkCreateVenvDialogCreatingVenv());
myPath = createEnvironment(basicSdk);
}
catch (ExecutionException e) {
Expand Down
6 changes: 3 additions & 3 deletions python-impl/src/main/java/com/jetbrains/python/impl/sdk/PythonSdkUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,11 @@ public void run(ProgressIndicator indicator) {
}
String sdkPresentableName = getSdkPresentableName(sdk);
LOG.info("Performing background update of skeletons for SDK " + sdkPresentableName);
indicator.setTextValue(LocalizeValue.localizeTODO("Updating skeletons..."));
indicator.setText(LocalizeValue.localizeTODO("Updating skeletons..."));
PySkeletonRefresher.refreshSkeletonsOfSdk(project1, ownerComponent, skeletonsPath, sdkInsideTask);
indicator.setIndeterminate(true);
indicator.setTextValue(LocalizeValue.localizeTODO("Scanning installed packages..."));
indicator.setText2Value(LocalizeValue.empty());
indicator.setText(LocalizeValue.localizeTODO("Scanning installed packages..."));
indicator.setText2(LocalizeValue.empty());
Comment on lines +161 to +165
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title mentions replacing setDescriptionValue → setDescription, but there don’t appear to be any setDescriptionValue usages in the repo (and none changed in this PR). Consider updating the title to reflect only the actual replacements, or include the missing setDescriptionValue change if it was intended.

Copilot uses AI. Check for mistakes.
LOG.info("Performing background scan of packages for SDK " + sdkPresentableName);
try {
PyPackageManager.getInstance(sdkInsideTask).refreshAndGetPackages(true);
Expand Down
6 changes: 3 additions & 3 deletions python-impl/src/main/java/com/jetbrains/python/impl/sdk/skeletons/PySkeletonRefresher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,14 @@ public PySkeletonRefresher(
private void indicate(LocalizeValue msg) {
if (myIndicator != null) {
myIndicator.checkCanceled();
myIndicator.setTextValue(msg);
myIndicator.setText2Value(LocalizeValue.empty());
myIndicator.setText(msg);
myIndicator.setText2(LocalizeValue.empty());
}
}

private void indicateMinor(String msg) {
if (myIndicator != null) {
myIndicator.setText2Value(LocalizeValue.ofNullable(msg));
myIndicator.setText2(LocalizeValue.ofNullable(msg));
}
}

Expand Down
Loading