Skip to content

refactor: Rename DefaulResolverTransformer to DefaultResolverTransformer #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Aug 22, 2023
Merged

refactor: Rename DefaulResolverTransformer to DefaultResolverTransformer #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/main/java/io/cloudquery/transformers/ResolverTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public interface ResolverTransformer {

ColumnResolver transform(Field field, String path) throws TransformerException;

class DefaulResolverTransformer implements ResolverTransformer {
class DefaultResolverTransformer implements ResolverTransformer {
@Override
public ColumnResolver transform(Field field, String path) throws TransformerException {
return (meta, resource, column) -> {
Expand Down
4 changes: 2 additions & 2 deletions lib/src/main/java/io/cloudquery/transformers/TransformWithClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static io.cloudquery.schema.Table.*;
import static io.cloudquery.transformers.IgnoreInTestsTransformer.DefaultIgnoreInTestsTransformer;
import static io.cloudquery.transformers.NameTransformer.DefaultNameTransformer;
import static io.cloudquery.transformers.ResolverTransformer.DefaulResolverTransformer;
import static io.cloudquery.transformers.TypeTransformer.DefaultTypeTransformer;

import io.cloudquery.schema.Column;
Expand All @@ -21,7 +20,8 @@ public class TransformWithClass implements Transform {
@Builder.Default private TypeTransformer typeTransformer = new DefaultTypeTransformer();

@Builder.Default
private ResolverTransformer resolverTransformer = new DefaulResolverTransformer();
private ResolverTransformer resolverTransformer =
new ResolverTransformer.DefaultResolverTransformer();

@Builder.Default
private IgnoreInTestsTransformer ignoreInTestsTransformer = new DefaultIgnoreInTestsTransformer();
Expand Down
6 changes: 3 additions & 3 deletions lib/src/test/java/io/cloudquery/transformers/DefaultResolverTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import io.cloudquery.scalar.ValidationException;
import io.cloudquery.schema.Column;
import io.cloudquery.schema.Resource;
import io.cloudquery.transformers.ResolverTransformer.DefaulResolverTransformer;
import io.cloudquery.transformers.ResolverTransformer.DefaultResolverTransformer;
import lombok.Builder;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand All @@ -24,13 +24,13 @@ public static class ResourceItem {
public String myCustomID;
}

private DefaulResolverTransformer transformer;
private DefaultResolverTransformer transformer;

@Mock private Resource resource;

@BeforeEach
void setUp() {
transformer = new DefaulResolverTransformer();
transformer = new DefaultResolverTransformer();

when(resource.getItem()).thenReturn(ResourceItem.builder().myCustomID("1234").build());
}
Expand Down