MINOR: Move TestSslUtils to client test fixtures#22201
Open
soarez wants to merge 2 commits intoapache:trunkfrom
Open
MINOR: Move TestSslUtils to client test fixtures#22201soarez wants to merge 2 commits intoapache:trunkfrom
soarez wants to merge 2 commits intoapache:trunkfrom
Conversation
This change moves TestSslUtils, TestUtils and accessory classes from the test classpath in clients to test fixtures, allowing other modules to use these classes for testing without having to include all of the test classpath for clients. For further details on the context and purpose of this change, check these threads: apache#20376 (comment) apache#22193 (comment)
chia7712
reviewed
May 4, 2026
| shadowed | ||
| } | ||
|
|
||
| // java-test-fixtures creates dependencies testImplementation -> testFixturesApi -> (main artifact) |
Member
There was a problem hiding this comment.
This is definitely a magic workaround... I noticed there are several issues discussing this behavior
gradle/gradle#19946
gradle/gradle#11696
Anyway, good job finding this approach!
|
|
||
| apply plugin: 'java-library' | ||
|
|
||
| // Resolve conflict between testFixtures and shadow in :clients. |
Member
There was a problem hiding this comment.
Could you add a comment referencing the "magic workaround" in the clients project?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves TestSslUtils, TestUtils and accessory classes from the
test classpath in clients to test fixtures, allowing other modules to
use these classes for testing without having to include all of the test
classpath for clients.
For further details on the context and purpose of this change, check
these threads:
#20376 (comment)
#22193 (comment)
Reviewers: Chia-Ping Tsai chia7712@gmail.com