Skip to content

build: remove rootDir from root configuration#33137

Merged
clydin merged 1 commit intoangular:mainfrom
clydin:cleanup-tsconfig-rootdir
May 6, 2026
Merged

build: remove rootDir from root configuration#33137
clydin merged 1 commit intoangular:mainfrom
clydin:cleanup-tsconfig-rootdir

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented May 6, 2026

Removing the rootDir option from the root tsconfig.json allows the TypeScript compiler to automatically compute the root directory based on the common path of all input files. This provides more flexibility in monorepo setups where files span across multiple top-level directories like packages and modules, avoiding strict location constraints that may not apply to all build targets.

Removing the rootDir option from the root tsconfig.json allows the TypeScript compiler to automatically compute the root directory based on the common path of all input files. This provides more flexibility in monorepo setups where files span across multiple top-level directories like packages and modules, avoiding strict location constraints that may not apply to all build targets.
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 6, 2026
@clydin clydin marked this pull request as ready for review May 6, 2026 15:08
@clydin clydin added the target: minor This PR is targeted for the next minor release label May 6, 2026
@clydin clydin requested a review from alan-agius4 May 6, 2026 15:09
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the redundant "rootDir" property from the tsconfig.json file, as "rootDirs" is already defined. I have no feedback to provide as there were no review comments to evaluate.

@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 6, 2026
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2026
@clydin clydin merged commit bf94764 into angular:main May 6, 2026
39 checks passed
@clydin
Copy link
Copy Markdown
Member Author

clydin commented May 6, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the cleanup-tsconfig-rootdir branch May 6, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants