Skip to content

Several deprecations#33127

Merged
alan-agius4 merged 6 commits intoangular:mainfrom
alan-agius4:webpack-deprecate
May 6, 2026
Merged

Several deprecations#33127
alan-agius4 merged 6 commits intoangular:mainfrom
alan-agius4:webpack-deprecate

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

No description provided.

@alan-agius4 alan-agius4 requested a review from clydin May 5, 2026 09:19
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label May 5, 2026
@alan-agius4 alan-agius4 marked this pull request as ready for review May 5, 2026 09:19
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 5, 2026
@alan-agius4 alan-agius4 force-pushed the webpack-deprecate branch from 555505e to 243e6dd Compare May 5, 2026 09:20
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the deprecation of Angular's Webpack-based build system across several packages, including @angular-devkit/build-angular, @angular-devkit/build-webpack, and @ngtools/webpack. Changes include adding deprecation metadata to the release configuration, marking various interfaces and classes with @deprecated JSDoc tags, and introducing runtime warning logs in builders to guide users toward the newer esbuild and Vite-based @angular/build package. I have no feedback to provide.

@alan-agius4 alan-agius4 force-pushed the webpack-deprecate branch from 243e6dd to adb2b98 Compare May 5, 2026 09:23
@clydin clydin requested a review from dgp1130 May 5, 2026 23:58
@alan-agius4 alan-agius4 removed the request for review from clydin May 6, 2026 05:42
Copy link
Copy Markdown
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider: Can we link to docs in log statements for the builders which aren't drop-in replacements?

The build system migration doc seems useful here. Not sure if there's a similar one for the old SSR builders.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2026
DEPRECATED: CommonEngine APIs are deprecated in favor of AngularNodeAppEngine or AngularAppEngine.
DEPRECATED: Webpack builders in build-angular are deprecated. Use @angular/build builders instead.
…k-dev-server builders

DEPRECATED: Webpack builders in build-webpack are deprecated. Use @angular/build builders instead.
DEPRECATED: @ngtools/webpack loader and plugin are deprecated. Use @angular/build instead.
Configures @angular-devkit/build-angular, @angular-devkit/build-webpack, and @ngtools/webpack as deprecated in the ng-dev release configuration.
…and ssr/node packages

Update golden files with deprecations.
@alan-agius4 alan-agius4 force-pushed the webpack-deprecate branch from 6f8258f to adf88a4 Compare May 6, 2026 16:35
@alan-agius4 alan-agius4 merged commit 23af499 into angular:main May 6, 2026
34 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the webpack-deprecate branch May 6, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr area: @angular-devkit/build-angular area: @angular-devkit/build-webpack area: build & ci Related the build and CI infrastructure of the project area: @ngtools/webpack detected: deprecation PR contains a commit with a deprecation target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants