Bugfix for #5: Altered output breaks functionality with strategy#7
Merged
leftrightleft merged 1 commit intoadvanced-security:mainfrom Jul 8, 2024
Merged
Conversation
Contributor
|
@CallMeGreg Can you take a look at this PR? This change reverts the updates you made in this PR |
Contributor
|
@leftrightleft LGTM 👍 |
leftrightleft
approved these changes
Jul 8, 2024
Contributor
leftrightleft
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix @LeShadow @gurucloudsec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that was in #5 .
The altered output from v1.1.0 gives an error when you use the output from the action in this type of context:
It cannot parse the JSON properly and thus the parsing ends in an empty value as well. This fix, which was mentioned in #5 should fix that.
Credit to the proposed fix by @gurucloudsec