Skip to content

chore: merge/backport fixes from staging to release#656

Closed
0xFA11 wants to merge 1 commit intorelease/0.1.0from
chore/backport-merge
Closed

chore: merge/backport fixes from staging to release#656
0xFA11 wants to merge 1 commit intorelease/0.1.0from
chore/backport-merge

Conversation

@0xFA11
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 commented Mar 23, 2021

we have some changes that went into chore/release-to-master branch which is basically the branch where we merge release/0.1.0 into master branch including merge conflict resolutions — it's currently being PR'd as #652.

  • backport TickSystemTests.VerifyTickSystem() fix (b2a54ec)
  • pull .github/ISSUES_TEMPLATE/* changes merged from master to chore/release-to-master
  • delete .editorconfig & .gitattributes files from the repository root
    • we have plans to replace .editorconfig with Unity C# Standards compliant one
    • we have plans to re-introduce .gitattributes including Unity Smart Merge (YAML Merge)

also, keep in mind that we'll ultimately merge release/0.1.0 branch into develop branch, delete release/0.1.0 branch after we're done with it and move on under develop branch (see Gitflow Workflow for the reference →).

Copy link
Copy Markdown
Contributor

@mattwalsh-unity mattwalsh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get this done. However, please make one commit for the documentation changes and a separate one for the tick testing code change.

@0xFA11 0xFA11 marked this pull request as draft March 23, 2021 16:18
@0xFA11
Copy link
Copy Markdown
Contributor Author

0xFA11 commented Mar 23, 2021

superseded by #658, #659 and #660

@0xFA11 0xFA11 closed this Mar 23, 2021
@0xFA11 0xFA11 deleted the chore/backport-merge branch March 23, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants