Skip to content

build: add Unity module dependencies explicitly #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 1 commit into from
Mar 19, 2021
+16 −14
Merged

build: add Unity module dependencies explicitly #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions com.unity.multiplayer.mlapi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
{
"name": "com.unity.multiplayer.mlapi",
"displayName": "MLAPI Networking Library",
"version": "0.1.0",
"unity": "2019.4",
"unityRelease": "8f1",
"description": "This the Core Unity Mid-level API that provides core SDK for multiplayer games within unity",
"keywords": [
"unity"
],
"type": "library",
"hideInEditor": false,
"dependencies": {
"com.unity.nuget.mono-cecil": "1.10.1-preview.1"
}
"name": "com.unity.multiplayer.mlapi",
Comment on lines -15 to +2
Copy link
Copy Markdown
Contributor Author

@0xFA11 0xFA11 Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rewrite is simply caused by spaces and things. I'm not changing anything other than the 2 new dependencies below, FYI.

"displayName": "MLAPI Networking Library",
"version": "0.1.0",
"unity": "2019.4",
"unityRelease": "8f1",
"description": "This the Core Unity Mid-level API that provides core SDK for multiplayer games within unity",
"keywords": [
"unity"
],
"type": "library",
"hideInEditor": false,
"dependencies": {
"com.unity.modules.ai": "1.0.0",
Copy link
Copy Markdown
Contributor Author

@0xFA11 0xFA11 Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for NetworkNavMeshAgent stuff

Copy link
Copy Markdown
Contributor

@mattwalsh-unity mattwalsh-unity Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ha, thanks for noting this!

"com.unity.modules.animation": "1.0.0",
Copy link
Copy Markdown
Contributor Author

@0xFA11 0xFA11 Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for NetworkAnimator stuff

"com.unity.nuget.mono-cecil": "1.10.1-preview.1"
}
}