build!: upgrade baseline Unity version from 2019.4 LTS to 2020.3 LTS#644
build!: upgrade baseline Unity version from 2019.4 LTS to 2020.3 LTS#6440xFA11 wants to merge 2 commits intorelease/0.1.0from
Conversation
| - 2021.1 | ||
| - 2021.2 | ||
| - 2020.3 | ||
| - 2019.4 |
There was a problem hiding this comment.
I'm not sure whether or not to kick 2019.4 out from Yamato CI/CD since we have plans to potentially downgrade back to 2019.4 in the future
| - Added message batching to handle consecutive RPC requests sent to the same client. `RpcBatcher` sends batches based on requests from the `RpcQueueProcessing`, by batch size threshold or immediately. | ||
| - [GitHub 494](https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi/pull/494): Added a constraint to allow one `NetworkObject` per `GameObject`, set through the `DisallowMultipleComponent` attribute. | ||
| - Integrated MLAPI with the Unity Profiler for versions 2020.2 and later: | ||
| - Integrated MLAPI with the Unity Profiler for versions 2020.3 and later: |
There was a problem hiding this comment.
I believe it should've been 2020.3 LTS instead of 2020.2 already — what you guys think? @lkrell @JesseOlmer
wackoisgod
left a comment
There was a problem hiding this comment.
I think this is the best option to be honest.
| #if !UNITY_2019_4_OR_NEWER | ||
| #error MLAPI requires Unity 2019.4 or newer | ||
| #if !UNITY_2020_3_OR_NEWER | ||
| #error MLAPI requires Unity 2020.3 or newer |
There was a problem hiding this comment.
this would cause a hard compile error on build immediately if somebody were to put MLAPI into a project older than 2020.3 such as 2020.1, 2019.4 etc.
should we keep this or should we rely on package manager, package.json and other things constraining people to get MLAPI on older versions? @mattwalsh-unity @JesseOlmer @seanstolberg-unity
| { | ||
| public class MLAPIProfiler : EditorWindow | ||
| { | ||
| #if !UNITY_2020_2_OR_NEWER |
There was a problem hiding this comment.
At this point, should this just be removed as a whole? Since we were keeping the MLAPIProfiler for version under 2020.2 but 2019.4+. Or for now we keep it like this and remove it whole for 1.0?
There was a problem hiding this comment.
we aren't fully decided to make 2020.3 LTS baseline version requirement permanent yet. we might consider jumping back to 2019.4 LTS if we get some fixes around ILPP issues we're having — so it's still TBD, that's why I'm still keeping pre-2020.3 blocks around :)
| "com.unity.modules.xr": "1.0.0" | ||
| }, | ||
| "testables": [ | ||
| "com.unity.multiplayer.mlapi" | ||
| ] | ||
| } | ||
| No newline at end of file | ||
| "dependencies": { | ||
| "com.unity.collab-proxy": "1.3.9", | ||
| "com.unity.ide.rider": "2.0.7", | ||
| "com.unity.ide.visualstudio": "2.0.7", | ||
| "com.unity.ide.vscode": "1.2.3", |
There was a problem hiding this comment.
changes in this file (under testproject) are due to 2019.4 to 2020.3 upgrade. package versions are being updated here.
| m_EditorVersion: 2019.4.17f1 | ||
| m_EditorVersionWithRevision: 2019.4.17f1 (667c8606c536) | ||
| m_EditorVersion: 2020.3.0f1 | ||
| m_EditorVersionWithRevision: 2020.3.0f1 (c7b5465681fb) |
There was a problem hiding this comment.
testproject is no longer on 2019.4 LTS and now on 2020.3 LTS version.
lkrell
left a comment
There was a problem hiding this comment.
Good from doc side, verified Profiler with Beck. Only Doc tweak: added Unity upgrade guide link in the manual.md.
Co-authored-by: Lori Krell <76010626+lkrell@users.noreply.github.com>
|
so, seems like #645 fixes 2019.4 ILPP issues. |
UNITY_2020_2_OR_NEWERwithUNITY_2020_3_OR_NEWER#error