Skip to content

fix: fixed network activity occurring outside the core update getting missed in the profiler #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 2 commits into from
Mar 18, 2021
Merged

fix: fixed network activity occurring outside the core update getting missed in the profiler #641

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba24d2d
fix: fixed network activity occurring outside the core update getting…
becksebenius-unity Mar 17, 2021
ff6e942
Merge branch 'release/0.1.0' into fix/missed-network-profiler-events
mattwalsh-unity Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,7 @@ public void NetworkUpdate(NetworkUpdateStage updateStage)

private void OnNetworkEarlyUpdate()
{
NotifyProfilerListeners();
ProfilerBeginTick();

if (IsListening)
Expand Down Expand Up @@ -755,8 +756,6 @@ private void OnNetworkPreUpdate()
m_CurrentNetworkTimeOffset += Mathf.Clamp(m_NetworkTimeOffset - m_CurrentNetworkTimeOffset, -maxDelta, maxDelta);
}
}

NotifyProfilerListeners();
}

internal void UpdateNetworkTime(ulong clientId, float netTime, float receiveTime, bool warp = false)
Expand Down