Skip to content

fix: Fix object traversal assigning instanceIds to none scene objects #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 2 commits into from
Mar 16, 2021
Merged

fix: Fix object traversal assigning instanceIds to none scene objects #629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2b6caf
fix: Fix object traversal assigning instanceIds to none scene objects
TwoTenPvP Mar 16, 2021
e87fb52
comment added
mattwalsh-unity Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.multiplayer.mlapi/Editor/PostProcessScene.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ public class NetworkScenePostProcess : MonoBehaviour
[PostProcessScene(int.MaxValue)]
public static void ProcessScene()
{
var traverseSortedObjects = FindObjectsOfType<NetworkObject>().ToList();
// find all scene objects that have not been spawned yet
// TODO: long term, replace the means of finding candidate objects to repace FindObjectsOfType
var traverseSortedObjects = FindObjectsOfType<NetworkObject>().Where(x => x.IsSceneObject == null).ToList();
Comment thread
mattwalsh-unity marked this conversation as resolved.

traverseSortedObjects.Sort((x, y) =>
{
Expand Down