Skip to content

Include instance ID in soft sync failure message #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 2 commits into from
Mar 15, 2021
Merged

Include instance ID in soft sync failure message #616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f49e1
Include instance ID in soft sync failure message
ThoseGrapefruits Mar 15, 2021
687ca14
Use explicit string format
ThoseGrapefruits Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions MLAPI/Spawning/SpawnManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,7 @@ internal static NetworkedObject CreateLocalNetworkedObject(bool softCreate, ulon
// SoftSync them by mapping
if (!pendingSoftSyncObjects.ContainsKey(instanceId))
{
// TODO: Fix this message
if (NetworkLog.CurrentLogLevel <= LogLevel.Error) NetworkLog.LogError("Cannot find pending soft sync object. Is the projects the same?");
if (NetworkLog.CurrentLogLevel <= LogLevel.Error) NetworkLog.LogError($"Cannot find pending SoftSync object [InstanceID={ instanceId }]. Are the projects the same?");
return null;
}

Expand Down