Conversation
| writer.WriteObjectPacked(true); | ||
| writer.WriteObjectPacked(false); |
There was a problem hiding this comment.
you might add other flavors of types here such as int[], INetworkSerializable, Vector3 etc to test a few other things too.
There was a problem hiding this comment.
Yes, this PR is just for the regression of the bool bug though. But I will test all the packed ones.
There was a problem hiding this comment.
ah, also Yamato fails because fix #541 went into release/0.1.0 and it's not on develop branch yet. so the test fails, which is very good! (except 2021.1 on Win passed? oh no...)
There was a problem hiding this comment.
And yes, I put int he PR description: "Expect this to fail until the fix for this has been backported to develop."
There was a problem hiding this comment.
Yea as for yamato. The tests failed on all machine. But pack and validate succeeded. Which is a good sign!
There was a problem hiding this comment.
@mattwalsh-unity was talking about merging release/0.1.0 back into develop some time soon. maybe we should that first and merge this in right afterwards?
0xFA11
left a comment
There was a problem hiding this comment.
I think this is good to go now!
(with an optional change suggestion)
Expect this to fail until the fix for this has been backported to develop.
Perhaps target release?