Skip to content

ci: Add conventional commit check for PRs#497

Merged
JesseOlmer merged 5 commits intodevelopfrom
ci/conventional-pr
Feb 25, 2021
Merged

ci: Add conventional commit check for PRs#497
JesseOlmer merged 5 commits intodevelopfrom
ci/conventional-pr

Conversation

@JesseOlmer
Copy link
Copy Markdown
Contributor

No description provided.

@JesseOlmer JesseOlmer changed the title ci: Add conventional commit check for PRs Add conventional commit check for PRs Feb 25, 2021
@JesseOlmer JesseOlmer changed the title Add conventional commit check for PRs ci: Add conventional commit check for PRs Feb 25, 2021
@JesseOlmer JesseOlmer requested a review from a team February 25, 2021 00:44
Comment thread .github/workflows/conventional-pr.yml Outdated
Comment on lines +20 to +22
# You may pin to the exact commit or the version.
# uses: amannn/action-semantic-pull-request@db6e259b93f286e3416eef27aaae88935d16cf2e
uses: amannn/action-semantic-pull-request@v3.4.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rely on this external repository or fork it under Unity-Technologies (and keep it up-to-date with the original repo when needed)? Personally, I'd suggest the latter.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you settle for a specific commit hash instead of a fork? You can't reference actions from private repos without a bunch of partial workarounds, and getting approval for another public repo is a very slow and involved process.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh sure, my point was "what if repo goes away?" but I think I'm fine with this too (this-is-fine emoji here)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing a specific commit hash now. Also added an (intentionally vague) comment about having a mirror of the repo on Unity github.

- Update the Conventional PR github action to reference a specific commit hash
- Added note about internal mirror in case the public repo is ever destroyed
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JesseOlmer JesseOlmer merged commit a950848 into develop Feb 25, 2021
@0xFA11 0xFA11 deleted the ci/conventional-pr branch March 5, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants