fix: Shutting down client or host/server and not being able to start the client or host/server within same game instance#496
Merged
NoelStephensUnity merged 29 commits intodevelopfrom Feb 25, 2021
Conversation
This fixes two issues: It prevents the postprocessing method ProcessScene from being run during scene transitions while in PlayMode within the editor. This fixes the issue where the transport is no longer being polled for events upon shutting down the server,host, or client.
This prevents this post processing code from being executed when in PlayMode (editor and stand alone build)
This ended up not being needed in the end. Reverting back to the original file.
Removing the commented out OnDisable function (the containing code was moved into the Shutdown method) and removed the Awake method (the containing code was moved into the Init method).
This hadn't fully registered the merge.
mattwalsh-unity
approved these changes
Feb 25, 2021
Contributor
mattwalsh-unity
left a comment
There was a problem hiding this comment.
LGTM, except for the comment addition I put in code. If you can stick in that comment SHIP IT
Added some comments regarding where the RpcQueueContainer should be instantiated and shutdown. Made the RpcQueueContainer internal, which also required me to make the QueueHistoryFrame internal and adjust some of the methods to match the same accessibility level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some initialization issues that occur when shutting down a client or server/host and not being able to re-establish a new networked gaming session from the same game build instance running or same editor PlayMode instance.
This moves the RPCQueueContainer instantiation and Network Update Loop registration into the Init method of the NetworkingManager and the deregistration from the Network Update Loop and destruction of the RpcQueueContainer into the NetworkingManager's shutdown method.
This PR fixes some of the issues for MTT-512