feat: FileLogger. A small utility to log to a file identified by proc…

[jeffreyrainy]

…ess ID. Useful when running multiple instances locally

[0xFA11]

instead of this, you should implement IDisposable with Dispose() method instead and put writer.Dispose() in it.
I also believe you could set AutoFlush to false and expose Flush() API.

[jeffreyrainy]

I agree with the dispose.
But not with the AutoFlush. Since this is debug functionality, you want the info to get out asap. You might be stopped on a breakpoint soon after, or get other crash/exceptions. Auto-flushing comes at very little cost and provides peace-of-mind that you'll get your logs.

[LukeStampfli]

Would this maybe be something which we want to put in the community-contributions repository instead of core MLAPI? Because it's not really related to MLAPI directly but more like a separate extension.

[jeffreyrainy]

Would this maybe be something which we want to put in the community-contributions repository instead of core MLAPI Because it's not really related to MLAPI directly but more like a separate extension.

I could agree, but what I'm after, here, is not just having a tool for myself. I'm trying to get a common set of tools that are already there and ready. So, for example, if there's a discussion between two developers and they want to test which approach is better, either one can just drop in a FileLogger::Get().Log("blah"), in any branch, on any project. If one has to install/add something else it defeats the whole purpose, in my view.

I'd totally buy "This doesn't belong in mlapi" and would keep it local for me. I'd accept this, no issue.
I wish we can have "This is not strictly mlapi, but it's a nice tool that will be ready and available"
But, "put it in a contrib beside" is a bit unsatisfactory, tbh.

[0xFA11]

LGTM! 🚀

[mattwalsh-unity]

For reference, here's another similar utility class https://github.com/hk1ll3r/UnityObjectLoggerExt

In particular
https://github.com/hk1ll3r/UnityObjectLoggerExt/blob/master/Assets/Scripts/UnityObjectLoggerExt.cs