fix: RpcQueueContainer deregister from NetworkUpdateManager#453
Merged
NoelStephensUnity merged 7 commits intodevelopfrom Jan 22, 2021
Merged
fix: RpcQueueContainer deregister from NetworkUpdateManager#453NoelStephensUnity merged 7 commits intodevelopfrom
NoelStephensUnity merged 7 commits intodevelopfrom
Conversation
This fixes the issue with the RpcQueueContainer not deregistering itself from the NetworkUpdateManager upon shutdown of the NetworkingManager.
Removing a comment that doesn't need to be there.
@jeffreyrainy suggested that the OnExiting method was confusing and it didn't make sense having more than one method to call in order to handle cleaning up and deregistering from the network update loop. These changes refactors the method used to handle shutting down.
jeffreyrainy
approved these changes
Jan 22, 2021
Removed call to ClearParameters method that was left over from legacy version when it was a static class.
After further discussions with Fraser, I am putting the ClearParameters method back.
fraserhutch2020
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the RpcQueueContainer would still be receiving network update loop callbacks even though the NetworkingManager had shutdown. The noticeable side effect of the bug would be exceptions thrown within the RpcQueueProcessing class as it tried to access NetworkingManager.Singleton.rpcQueueContainer.
This fix combines the OnExiting method with the Shutdown method, removes the OnExiting method, and assures it will be deregistered from the network update loop when Shutdown is called.