feat: RPC Network Update Order and Network Update Loop Registration by NoelStephensUnity · Pull Request #442 · Unity-Technologies/com.unity.netcode.gameobjects

NoelStephensUnity · 2021-01-14T00:17:00Z

MTT-174
This commit provides the ability to:

specify at what network update stage an RPC will be invoked on the receiver side.
create new network update loop systems that can register an Action with a specific network update loop stage.

Ancillary information:

Networking Manager only registers for the PreUpdate and Update stages and now derives from the UpdateLoopBehaviour class (used for MonoBehaviour dependent classes).
RpcQueueContainer (formally RpcQueueManager) now registers for all network loop update stages and now derives from the GenericUpdateLoopSystem (for generic classes that don't have MonoBehaviour or NetworkedBehaviour dependencies)
There is also a NetworkUpdateLoopBehaviour class that is a Network Update Loop aware NetworkedBehaviour.

Additional updates unrelated to MTT-174:

This also provides the ability to enable or disable RPC Batching in the event there is a need to do this for some reason in the future.
Hot Fix: RPC Batch Jitter-bug MTT-408

This branch *is not for any prouction use*, but is for a quick holiday port of a Unity Lesson (Chapter 17: Zombie Toys) to a client server architecture. This currently only supports single player (server authoritative client) and the monster AI (server authoritative). This branch, however, does include some potential fixes to potential bugs in the current development branch.

Some interesting changes. Had to add a "destroy" parm to be able to use registered custom destroy callbacks.

Just some tweaks and a useful way to get notified the network session is shutting down.

Added first pass implementation of RPC invocation update stage assignment. RPCs can now be assigned a specific update stage for the RPC to be invoked.

Starting to get new network update loop registration into place.

Tracking down additional issues.

The rest of the changes for the RPC Queue Revisited jira task MTT-327.

MTT-367 Finalizing some adjustment to conform to the naming standards. Predominantly updating member property names and formating related changes.

minor update

…update" This reverts commit 5d75987, reversing changes made to 39f0502.

…/networkupdate"" This reverts commit 9a09588.

Making adjustments from the merge of develop

The RPCQueueRevisited kind of threw this branch into chaos. These are some of the fixes for the merge issue.

Lost some of the batching changes, also wanted to keep the original RPC Send methods.

This just fixes some of the stutter associated with batching.

Added a more modular way to register with the network loop update system. This includes four possible paths: Add the INetworkUpdateLoopSystem to your class declaration and provide the appropriate methods. =or= Derive your class from: GenericUpdateLoopSystem for a slim non-monobehavior derived class. UpdateLoopBehaviour for a MonoBehaviour derived class. NetworkUpdateLoopBehaviour for a NetworkedBehaviour derived class. NetworkingManager now only is updated during the PREUPDATE and UPDATE stages. RpcQueueContainer now automatically registers for all update stages but also provides the ability for one to handle RPC queue processing externally (i.e.. at different stages).

The updated names and formating for Unity standards will be coming in the RPCQueueRevisited PR

This just applies the fix for bool reading and writing PR #438

Removed the code that extracted the host client id from the connected client list as the bug that invoked that change was finally found and not related to this temporary fix. Did some standards clean up.

Had to refactor some of the code based on current state of develop branch.

…han 2 clients

jeffreyrainy · 2021-01-14T01:38:27Z

Added HotFix for MessageBatching: using different writers for different SendStreams.

0xFA11

I'll have another thorough look at this PR.

The majority of these changes are syntax/standard oriented, but there are a few good catches like removing C# 8.0 standard "using", try an catches left in, and some const definitions for some of the RPC queue related boundary checking.

Removing the ifdef.

Moving the RPC queue related files to the Messaging directory since they are within the same namespace (and it is the proper location for them).

NoelStephensUnity added 26 commits December 27, 2020 13:18

More changes

87bd6d9

Some interesting changes. Had to add a "destroy" parm to be able to use registered custom destroy callbacks.

Minor updates

4acce29

Just some tweaks and a useful way to get notified the network session is shutting down.

MTT-174

16cce8b

Added first pass implementation of RPC invocation update stage assignment. RPCs can now be assigned a specific update stage for the RPC to be invoked.

Merge branch 'develop' into feature/networkupdate

548280b

WIP

755009c

Starting to get new network update loop registration into place.

WIP

39f0502

Tracking down additional issues.

MTT-327

cadac6a

The rest of the changes for the RPC Queue Revisited jira task MTT-327.

Merge branch 'develop' into feature/rpcqueuerevisited

d130e99

MTT-367 MTT-327

00eda77

MTT-367 Finalizing some adjustment to conform to the naming standards. Predominantly updating member property names and formating related changes.

Minor update

e1dc42f

minor update

Merge branch 'feature/rpcqueuerevisited' into feature/networkupdate

5d75987

Revert "Merge branch 'feature/rpcqueuerevisited' into feature/network…

9a09588

…update" This reverts commit 5d75987, reversing changes made to 39f0502.

Revert "Revert "Merge branch 'feature/rpcqueuerevisited' into feature…

7b10b5e

…/networkupdate"" This reverts commit 9a09588.

Develop Merge Adjustments

4e99f6f

Making adjustments from the merge of develop

Cluster-Merge

95bd375

The RPCQueueRevisited kind of threw this branch into chaos. These are some of the fixes for the merge issue.

Merge Fix - Batching

a0032b5

Lost some of the batching changes, also wanted to keep the original RPC Send methods.

Fixes for Batching

4fb8d9b

This just fixes some of the stutter associated with batching.

Merge branch 'develop' into feature/networkupdate

c95547f

fix: updated legacy name from rpcQueueMananger to rpcQueueContainer

aa9bfa3

The updated names and formating for Unity standards will be coming in the RPCQueueRevisited PR

fix: removed line between properties

451461b

refactor: Updated for BitReader BitWriter bool

dda716b

This just applies the fix for bool reading and writing PR #438

refactor: Fixes and Standards

e103a95

Removed the code that extracted the host client id from the connected client list as the bug that invoked that change was finally found and not related to this temporary fix. Did some standards clean up.

Merge branch 'develop' into feature/networkupdate

b23eabb

refactor: develop branch merge

a80ea9c

Had to refactor some of the code based on current state of develop branch.

NoelStephensUnity requested review from 0xFA11 and jeffreyrainy January 14, 2021 00:17

fix: Using different writers per SendStream, to fix issue with more t…

ba66825

…han 2 clients