Skip to content

refactor: rpcqueue#433

Merged
0xFA11 merged 10 commits intodevelopfrom
feature/rpcqueuerevisited
Jan 13, 2021
Merged

refactor: rpcqueue#433
0xFA11 merged 10 commits intodevelopfrom
feature/rpcqueuerevisited

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented Jan 8, 2021

This PR addresses both the suggestions made in the original RPCQueue PR and additional unity coding conventions standards adjustments.

NoelStephensUnity and others added 5 commits January 7, 2021 17:19
@NoelStephensUnity
MTT-327
cadac6a 
The rest of the changes for the RPC Queue Revisited jira task MTT-327.
@NoelStephensUnity
Merge branch 'develop' into feature/rpcqueuerevisited
d130e99
@NoelStephensUnity
MTT-367 MTT-327
00eda77 
MTT-367 Finalizing some adjustment to conform to the naming standards.
Predominantly updating member property names and formating related changes.
@NoelStephensUnity
Minor update
e1dc42f 
minor update
@0xFA11
Merge branch 'develop' into feature/rpcqueuerevisited
320d90f
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/NetworkUpdateManager.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/NetworkedBehaviour.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/NetworkedBehaviour.cs Outdated
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/NetworkingManager.cs Outdated
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/FrameQueueItem.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/QueueHistoryFrame.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueContainer.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueProcessing.cs
0xFA11
0xFA11 reviewed Jan 9, 2021
View reviewed changes
Comment thread com.unity.multiplayer.mlapi/Runtime/Transports/Transport.cs
0xFA11
0xFA11 approved these changes Jan 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (ship-it-parrot)

@NoelStephensUnity
fix: for renamed RPCQueueManager and camelCase
dde21b4 
fixing minor camelCase updates and naming update.
@NoelStephensUnity
fix: more naming update fixes
af6b2d4 
Some legacy names found there way back into this branch from develop.
@NoelStephensUnity NoelStephensUnity changed the title Feature/rpcqueuerevisited refactor: rpcqueue Jan 12, 2021
@0xFA11 0xFA11 merged commit 528813a into develop Jan 13, 2021
@NoelStephensUnity NoelStephensUnity deleted the feature/rpcqueuerevisited branch March 2, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0xFA11 0xFA11 0xFA11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity @0xFA11