Fix/migration cleanup lost changes#417
Merged
mattwalsh-unity merged 4 commits intodevelopfrom Jan 8, 2021
Merged
Conversation
| objectsToDestroy.Add(pair.Value); | ||
| } | ||
|
|
||
| for (int i = 0; i < objectsToDestroy.Count; i++) |
Contributor
There was a problem hiding this comment.
Worth a comment to say why we batch the objects before then destroying them.
| } | ||
|
|
||
| // Clean up the diffed scene objects. I.E scene objects that have been destroyed | ||
| if (SpawnManager.pendingSoftSyncObjects.Count > 0) |
Contributor
There was a problem hiding this comment.
Could this be hoisted into a function inside SpawnManager? There are other functions like this e.g. DestroySceneObjects
Contributor
There was a problem hiding this comment.
Ok, just pushed a commit to refactor this a bit
mattwalsh-unity
suggested changes
Jan 4, 2021
Contributor
mattwalsh-unity
left a comment
There was a problem hiding this comment.
Some organization comments
Contributor
|
Confirmed these commits were not removed on purpose, but on looking at them seems like they could be organized a bit first |
mattwalsh-unity
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds features and bug fixes which were removed by accident when merging our internal changes into the new develop branch.
Albin already approved this PR in our internal repo. @mattwalsh-unity since you made the commits which migrated those, could you confirm that these (especially the soft sync object part) weren't removed on purpose?