ci: Update yamato templates#401
Merged
JesseOlmer merged 8 commits intodevelopfrom Dec 11, 2020
Merged
Conversation
added 5 commits
December 9, 2020 15:53
Our custom CI configuration started failing after a change in the upm-ci tool. This change updates the CI configuration to use the standard templates for multi-package repositories. As a side effect, it also introduces a test/sample project where we can exercise the packages and put tests we don't want to ship with the packages themselves. Tests run against 2020.1 and trunk, on windows, mac, and ubuntu
The root gitignore removed all "packages" directories globally as a nuget-related ignore, but this has the unintended side-effect of ignoring a Unity project Packages folder, which is integral to how CI discovers the packages we build. This change adds a targeted exception for the testproject Packages folder.
MLAPI package tests now trigger on pull request commits targeting develop
Added package tests to the "All Tests" job. Previous behavior was only project tests (which are currently empty)
Templating code was commented out incorrectly and so was still being executed. This caused a UI bug on the Yamato website displaying duplicates of the same jobs. This change also removes the direct package test dependencies from the "all tests" job, as they're pulled in through the "badges test trigger" dependency on that job.
ci: Fixing some validation issues ci: Fixed issues with description and exception ci: Fixed error
…lates-fixes ci: Fixes some validation issues
wackoisgod
approved these changes
Dec 11, 2020
This change enables package validation (for the MLAPI package only) on pull request changes targeting develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other jobs (e.g. tests for other packages, package standards validation tests, publish to package registry) are still completely manually triggered.